8254103: Shenandoah: Move updating thread roots to concurrent phase

[zhengyu123]

Due to non-atomic LRB, there can be from-space oops in thread roots after evacuation.
To enforce to-space invariant, Shenandoah updates thread roots during final reference updating pause, but it can be done outside pause via thread handshake.

Test:

• hotspot_gc_shenandoah

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x64	Windows x64	macOS x64
Build	✔️ (3/3 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	✔️ (9/9 passed)	❌ (1/9 failed)	✔️ (9/9 passed)

Failed test task

• Windows x64 (langtools/tier1)

Issue

• JDK-8254103: Shenandoah: Move updating thread roots to concurrent phase

Reviewers

• Roman Kennke (@rkennke - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/541/head:pull/541
$ git checkout pull/541

[bridgekeeper]

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zhengyu123 The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (5dd16f5)
• 00: Full (18bfac3)

[rkennke]

Looks good to me! Thanks!

[openjdk]

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254103: Shenandoah: Move updating thread roots to concurrent phase

Reviewed-by: rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

• 7e82ba1: 8254146: Avoid unnecessary volatile write on new AtomicBoolean(false)
• 6d13c76: 8253191: C2: Masked byte comparisons with large masks produce wrong result on x86
• a191c58: 8253404: C2: assert(C->live_nodes() <= C->max_node_limit()) failed: Live Node limit exceeded limit
• 6bc4931: 8253717: Relocate stack overflow code out of thread.hpp/cpp
• 782d45b: 8242882: opening jar file with large manifest might throw NegativeArraySizeException
• f860372: 8253566: clazz.isAssignableFrom will return false for interface implementors
• 66f27b5: 8254015: copy_to_survivor_space should use in-hand klass for scanning
• 76a5852: 8253756: C2 CompilerThread0 crash in Node::add_req(Node*)
• 8f9e479: 8254144: Non-x86 Zero builds fail with return-type warning in os_linux_zero.cpp
• 7952c06: 8254166: Zero: return-type warning in zeroInterpreter_zero.cpp
• ... and 29 more: https://git.openjdk.java.net/jdk/compare/54b340b44f1f3dca2c3f3e8cd2abd8196e0027d8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[zhengyu123]

/integrate

[openjdk]

@zhengyu123 Since your change was applied there have been 39 commits pushed to the master branch:

• 7e82ba1: 8254146: Avoid unnecessary volatile write on new AtomicBoolean(false)
• 6d13c76: 8253191: C2: Masked byte comparisons with large masks produce wrong result on x86
• a191c58: 8253404: C2: assert(C->live_nodes() <= C->max_node_limit()) failed: Live Node limit exceeded limit
• 6bc4931: 8253717: Relocate stack overflow code out of thread.hpp/cpp
• 782d45b: 8242882: opening jar file with large manifest might throw NegativeArraySizeException
• f860372: 8253566: clazz.isAssignableFrom will return false for interface implementors
• 66f27b5: 8254015: copy_to_survivor_space should use in-hand klass for scanning
• 76a5852: 8253756: C2 CompilerThread0 crash in Node::add_req(Node*)
• 8f9e479: 8254144: Non-x86 Zero builds fail with return-type warning in os_linux_zero.cpp
• 7952c06: 8254166: Zero: return-type warning in zeroInterpreter_zero.cpp
• ... and 29 more: https://git.openjdk.java.net/jdk/compare/54b340b44f1f3dca2c3f3e8cd2abd8196e0027d8...master

Your commit was automatically rebased without conflicts.

Pushed as commit d036dca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.