-
Notifications
You must be signed in to change notification settings - Fork 6k
8272515: JFR: Names should only be valid Java identifiers #5415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into |
/csr |
@egahlin this pull request will not be integrated until the CSR request JDK-8272516 for issue JDK-8272515 has been approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@egahlin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 151 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 48aff23.
Your commit was automatically rebased without conflicts. |
Hi,
Could I have a review of change that prevents invalid Java identifiers or type names in JFR events. For rationale and compatibility issues see the CSR request. The only change to java.base is making jdk.modules.internal.Checks::isJavaIdentifier(String) public, so it can be reused by the jdk.jfr module.
Testing: /jdk/jdk/jfr + tier1 + tier2
Thanks
Erik
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5415/head:pull/5415
$ git checkout pull/5415
Update a local copy of the PR:
$ git checkout pull/5415
$ git pull https://git.openjdk.java.net/jdk pull/5415/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5415
View PR using the GUI difftool:
$ git pr show -t 5415
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5415.diff