8273358: macOS Monterey does not have the font Times needed by Serif

[prrace]

Times has been the hard coded name for Serif in the JDK sources for macOS since the port was contributed by Apple.
But it seems that macOS Monterey doesn't have this font.
And the hard-coded fallback is also Times ! So we end up returning Dialog which is very bad.

The safest fix here is to make Times New Roman the fall back, so that on older macOS versions there
is absolutely no change. Only on Monterey and presumably later, will it use Times New Roman which,
I suspect, is what Times actually ends up being anyway.

Also to prevent unconditional warnings being printed I needed to change those to be conditional on logging being set.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8273358: macOS Monterey does not have the font Times needed by Serif

Reviewers

• Alexander Zuev (@azuev-java - Reviewer)
• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5420/head:pull/5420
$ git checkout pull/5420

Update a local copy of the PR:
$ git checkout pull/5420
$ git pull https://git.openjdk.java.net/jdk pull/5420/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5420

View PR using the GUI difftool:
$ git pr show -t 5420

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5420.diff

[bridgekeeper]

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prrace The following label will be automatically applied to this pull request:

• 2d

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e773c737)

[openjdk]

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273358: macOS Monterey does not have the font Times needed by Serif

Reviewed-by: kizune, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

• c1e39fa: 8273482: Remove "foreground work" concept from WorkGang
• 2eaf374: 8272698: LoadNode::pin is unused
• 792281d: 8264517: C2: make MachCallNode::return_value_is_used() only available for x86
• 70c9e02: 8272148: JDesktopPane:getComponentCount() returns one extra than expected with GTKLookAndFeel
• 08f0be8: 8272608: java_lang_System::allow_security_manager() doesn't set its initialization flag
• 2e321dc: 8273528: Avoid ByteArrayOutputStream.toByteArray when converting stream to String
• 54dee13: 8273188: java/lang/instrument/BootClassPath/BootClassPathTest.sh fails with "FATAL ERROR in native method: processing of -javaagent failed, processJavaStart failed"
• 4020a60: 8273550: Replace os::cgc_thread/pgc_thread with os::gc_thread
• 185eaca: 8273545: Remove Thread::is_GC_task_thread()
• dd1209e: 8268885: duplicate checkcast when destination type is not first type of intersection type
• ... and 44 more: https://git.openjdk.java.net/jdk/compare/df05b4d1a13e55755107695ad9ea7a8a1084901a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[prrace]

/integrate

[openjdk]

Going to push as commit efe3ed1.
Since your change was applied there have been 61 commits pushed to the master branch:

• e58c12e: 8273512: Fix the copyright header of x86 macroAssembler files
• 461a467: 8273456: Do not hold ttyLock around stack walking
• 695b434: Merge
• 4afbcaf: 8273592: Backout JDK-8271868
• a37254c: 8271868: Warn user when using mac-sign option with unsigned app-image.
• c464f09: 8273402: Use derived NamingExceptions in com.sun.jndi.ldap.Connection#readReply
• 4e6de5f: 8273541: Cleaner Thread creates with normal priority instead of MAX_PRIORITY - 2
• c1e39fa: 8273482: Remove "foreground work" concept from WorkGang
• 2eaf374: 8272698: LoadNode::pin is unused
• 792281d: 8264517: C2: make MachCallNode::return_value_is_used() only available for x86
• ... and 51 more: https://git.openjdk.java.net/jdk/compare/df05b4d1a13e55755107695ad9ea7a8a1084901a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prrace Pushed as commit efe3ed1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.