Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273109: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest times out #5422

Closed
wants to merge 1 commit into from

Conversation

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Sep 8, 2021

A trivial fix to increase the timeouts for the two sub-tests in
runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273109: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest times out

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5422/head:pull/5422
$ git checkout pull/5422

Update a local copy of the PR:
$ git checkout pull/5422
$ git pull https://git.openjdk.java.net/jdk pull/5422/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5422

View PR using the GUI difftool:
$ git pr show -t 5422

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5422.diff

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Sep 8, 2021

/label add hotspot-runtime

Loading

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Sep 8, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 8, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

bplb
bplb approved these changes Sep 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273109: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest times out

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

Loading

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Sep 8, 2021

@bplb - Thanks for the lightning fast review!

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

Going to push as commit ba31eee.

Loading

@openjdk openjdk bot closed this Sep 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

@dcubed-ojdk Pushed as commit ba31eee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 8, 2021

Webrevs

Loading

Copy link
Member

@mseledts mseledts left a comment

Looks good to me.

Loading

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Sep 8, 2021

@mseledts - Thanks for the review. It was after the integration
so you won't be listed. Sorry about that.

Loading

@dcubed-ojdk dcubed-ojdk deleted the JDK-8273109 branch Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants