Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271569: Clean up the use of CDS constants and field offsets #5423

Closed
wants to merge 1 commit into from

Conversation

yminqi
Copy link
Contributor

@yminqi yminqi commented Sep 8, 2021

Changed cdsOffsets.cpp to cdsConstants.cpp, now the offsets and constants are initialized static and searched separately.
The offsets array could not use 'constexpr' since g++ on MacOs and VSC++ on Windows complained reinterpret_cast in 'offset_of' should not be used in constexpr initialization. Changed some field access for forming global list first.

Tests: ter1-4

Thanks
Yumin


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271569: Change cdsoffsets.cpp to cdsConstants.cpp

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5423/head:pull/5423
$ git checkout pull/5423

Update a local copy of the PR:
$ git checkout pull/5423
$ git pull https://git.openjdk.java.net/jdk pull/5423/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5423

View PR using the GUI difftool:
$ git pr show -t 5423

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5423.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 8, 2021

👋 Welcome back minqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 8, 2021
@openjdk
Copy link

openjdk bot commented Sep 8, 2021

@yminqi The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Sep 8, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 8, 2021

Webrevs

@yminqi
Copy link
Contributor Author

yminqi commented Sep 8, 2021

/label add hotspot-runtime

@openjdk openjdk bot added the hotspot-runtime label Sep 8, 2021
@openjdk
Copy link

openjdk bot commented Sep 8, 2021

@yminqi
The hotspot-runtime label was successfully added.

@dholmes-ora
Copy link
Member

dholmes-ora commented Sep 8, 2021

Hi Yumin,

Changed cdsOffsets.cpp to cdsConstants.cpp

This is not showing up in the PR as a rename but as a new file. So there is no way to know what changes you may have made inside cdsConstants.cpp. The header file change shows as a rename.

David

@yminqi
Copy link
Contributor Author

yminqi commented Sep 9, 2021

Hi Yumin,

Changed cdsOffsets.cpp to cdsConstants.cpp

This is not showing up in the PR as a rename but as a new file. So there is no way to know what changes you may have made inside cdsConstants.cpp. The header file change shows as a rename.

David

Hi, David
git did not rename the 'old' to 'new' so the patch showed cdsConstants.cpp as a 'new' file. So I will change description as you indicated. Thanks

Yumin

@yminqi yminqi changed the title 8271569: Rename cdsoffsets.cpp to cdsConstants.cpp 8271569: Change cdsoffsets.cpp to cdsConstants.cpp Sep 9, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 9, 2021

Mailing list message from David Holmes on hotspot-dev:

On 9/09/2021 1:16 pm, Yumin Qi wrote:

On Wed, 8 Sep 2021 22:44:14 GMT, David Holmes <dholmes at openjdk.org> wrote:

Hi Yumin,

Changed cdsOffsets.cpp to cdsConstants.cpp

This is not showing up in the PR as a rename but as a new file. So there is no way to know what changes you may have made inside cdsConstants.cpp. The header file change shows as a rename.

David

Hi, David
git did not rename the 'old' to 'new' so the patch showed cdsConstants.cpp as a 'new' file. So I will change description as you indicated. Thanks

?? I'd rather you try again and do a rename :) Otherwise please advise
what, if any, changes were actually made to the "new" file?

Thanks,
David

@yminqi
Copy link
Contributor Author

yminqi commented Sep 9, 2021

@dholmes-ora I see your point here --- let me redo the patch using rename.

@yminqi yminqi closed this Sep 9, 2021
@yminqi yminqi deleted the jdk-8271569 branch Sep 9, 2021
@yminqi yminqi changed the title 8271569: Change cdsoffsets.cpp to cdsConstants.cpp 8271569: Clean up the use of CDS constants and field offsets Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-runtime rfr
2 participants