New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8273512: Fix the copyright header of x86 macroAssembler files #5424
Conversation
|
/label hotspot-compiler |
@sviswa7 |
Webrevs
|
Hi Sandhya,
Hotspot files do not have the "Classpath exception".
Thanks,
David
Thanks @dholmes-ora. I have removed the classpath exception. Let me know if the patch looks good to you now. |
Hi Sandhya,
Under the assumption that this is indeed the right way to apply Intel copyrights I can approve this PR.
Thanks,
David
@sviswa7 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 50 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
What about this one?
* Copyright (c) 2016, Intel Corporation. |
Other files look good and consistent with the Intel copyright in src/jdk.incubator.vector/linux/native/libsvml/*
.
Thanks a lot @TobiHartmann. I have corrected that line as well. |
/integrate |
Going to push as commit e58c12e.
Your commit was automatically rebased without conflicts. |
Fix the copyright header of x86 macroAssembler files to match others.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5424/head:pull/5424
$ git checkout pull/5424
Update a local copy of the PR:
$ git checkout pull/5424
$ git pull https://git.openjdk.java.net/jdk pull/5424/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5424
View PR using the GUI difftool:
$ git pr show -t 5424
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5424.diff