Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273512: Fix the copyright header of x86 macroAssembler files #5424

Closed
wants to merge 3 commits into from

Conversation

sviswa7
Copy link

@sviswa7 sviswa7 commented Sep 8, 2021

Fix the copyright header of x86 macroAssembler files to match others.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273512: Fix the copyright header of x86 macroAssembler files

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5424/head:pull/5424
$ git checkout pull/5424

Update a local copy of the PR:
$ git checkout pull/5424
$ git pull https://git.openjdk.java.net/jdk pull/5424/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5424

View PR using the GUI difftool:
$ git pr show -t 5424

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5424.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 8, 2021

👋 Welcome back sviswanathan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

@sviswa7 The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Sep 8, 2021
@sviswa7
Copy link
Author

@sviswa7 sviswa7 commented Sep 8, 2021

/label hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler label Sep 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

@sviswa7
The hotspot-compiler label was successfully added.

@sviswa7 sviswa7 marked this pull request as ready for review Sep 8, 2021
@openjdk openjdk bot added the rfr label Sep 8, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 8, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Hi Sandhya,

Hotspot files do not have the "Classpath exception".

Thanks,
David

@sviswa7
Copy link
Author

@sviswa7 sviswa7 commented Sep 9, 2021

Thanks @dholmes-ora. I have removed the classpath exception. Let me know if the patch looks good to you now.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Hi Sandhya,

Under the assumption that this is indeed the right way to apply Intel copyrights I can approve this PR.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

@sviswa7 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273512: Fix the copyright header of x86 macroAssembler files

Reviewed-by: dholmes, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

  • 08f0be8: 8272608: java_lang_System::allow_security_manager() doesn't set its initialization flag
  • 2e321dc: 8273528: Avoid ByteArrayOutputStream.toByteArray when converting stream to String
  • 54dee13: 8273188: java/lang/instrument/BootClassPath/BootClassPathTest.sh fails with "FATAL ERROR in native method: processing of -javaagent failed, processJavaStart failed"
  • 4020a60: 8273550: Replace os::cgc_thread/pgc_thread with os::gc_thread
  • 185eaca: 8273545: Remove Thread::is_GC_task_thread()
  • dd1209e: 8268885: duplicate checkcast when destination type is not first type of intersection type
  • ef4a532: 8263773: Reenable German localization for builds at Oracle
  • 96614da: 8272903: Missing license header in ArenaAllocator.java
  • e3bda63: 8273489: Zero: Handle UseHeavyMonitors on all monitorenter paths
  • c81690d: 8273498: compiler/c2/Test7179138_1.java timed out
  • ... and 40 more: https://git.openjdk.java.net/jdk/compare/df05b4d1a13e55755107695ad9ea7a8a1084901a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 9, 2021
Copy link
Member

@TobiHartmann TobiHartmann left a comment

What about this one?

* Copyright (c) 2016, Intel Corporation.

Other files look good and consistent with the Intel copyright in src/jdk.incubator.vector/linux/native/libsvml/*.

@sviswa7
Copy link
Author

@sviswa7 sviswa7 commented Sep 9, 2021

Thanks a lot @TobiHartmann. I have corrected that line as well.

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me.

@sviswa7
Copy link
Author

@sviswa7 sviswa7 commented Sep 10, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

Going to push as commit e58c12e.
Since your change was applied there have been 60 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 10, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

@sviswa7 Pushed as commit e58c12e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sviswa7 sviswa7 deleted the macroheader branch Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-compiler integrated
3 participants