Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273366: [testbug] javax/swing/UIDefaults/6302464/bug6302464.java fails on macOS12 #5434

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Sep 9, 2021

Test fails on macOS12 since the check was only upto macOS11..Extended the check for BigSurOrAbove.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273366: [testbug] javax/swing/UIDefaults/6302464/bug6302464.java fails on macOS12

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5434/head:pull/5434
$ git checkout pull/5434

Update a local copy of the PR:
$ git checkout pull/5434
$ git pull https://git.openjdk.java.net/jdk pull/5434/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5434

View PR using the GUI difftool:
$ git pr show -t 5434

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5434.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 9, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

@prsadhuk The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing label Sep 9, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 9, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273366: [testbug] javax/swing/UIDefaults/6302464/bug6302464.java fails on macOS12

Reviewed-by: aivanov, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 131 new commits pushed to the master branch:

  • e66bf47: 8273414: ResourceObj::operator delete should handle nullptr in debug builds
  • 16c3ad1: 8272574: C2: assert(false) failed: Bad graph detected in build_loop_late
  • e7ab372: 8273641: (bf) Buffer subclasses documentation contains template strings
  • 22a7191: 8273040: Turning off JpAllowDowngrades (or Upgrades)
  • 394ebc8: 8270553: Tests should not use (real, in-use, routable) 1.1.1.1 as dummy IP value
  • 0f31d0f: 8273373: Zero: Cannot invoke JVM in primordial threads on Zero
  • fe89dd3: 8271254: javac generates unreachable code when using empty semicolon statement
  • 8974b95: 8273730: WorkGangBarrierSync constructor unused
  • 1d3eb14: 8273635: Attempting to acquire lock StackWatermark_lock/9 out of order with lock tty_lock/3
  • 31667da: 8273491: java.util.spi.LocaleServiceProvider spec contains statement that is too strict
  • ... and 121 more: https://git.openjdk.java.net/jdk/compare/8c379092747301de70db1ef8e441cbe09fd742e7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready client labels Sep 9, 2021
@mrserb
Copy link
Member

@mrserb mrserb commented Sep 12, 2021

Since the test initially started to fail after JDK-8220150
probably it will be good to use the same logic in the test and in the jdk, see
https://hg.openjdk.java.net/jdk/jdk/rev/a57d3822c2fa#l2.16
?

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Sep 13, 2021

I guess the test failure is initially reported in JDK-8199079 which was way before JDK-8220150 and it has passed ever since that fix. We are just extending the fix to macos12 and beyond.

mrserb
mrserb approved these changes Sep 15, 2021
Copy link
Member

@mrserb mrserb left a comment

ok

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Sep 15, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

Going to push as commit febcc72.
Since your change was applied there have been 133 commits pushed to the master branch:

  • 1017a2c: 8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7
  • 6cf70f5: 8273638: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F
  • e66bf47: 8273414: ResourceObj::operator delete should handle nullptr in debug builds
  • 16c3ad1: 8272574: C2: assert(false) failed: Bad graph detected in build_loop_late
  • e7ab372: 8273641: (bf) Buffer subclasses documentation contains template strings
  • 22a7191: 8273040: Turning off JpAllowDowngrades (or Upgrades)
  • 394ebc8: 8270553: Tests should not use (real, in-use, routable) 1.1.1.1 as dummy IP value
  • 0f31d0f: 8273373: Zero: Cannot invoke JVM in primordial threads on Zero
  • fe89dd3: 8271254: javac generates unreachable code when using empty semicolon statement
  • 8974b95: 8273730: WorkGangBarrierSync constructor unused
  • ... and 123 more: https://git.openjdk.java.net/jdk/compare/8c379092747301de70db1ef8e441cbe09fd742e7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

@prsadhuk Pushed as commit febcc72.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8273366 branch Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client integrated swing
3 participants