Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8264517: C2: make MachCallNode::return_value_is_used() only available for x86 #5435

Closed
wants to merge 2 commits into from

Conversation

@tobiasholenstein
Copy link
Contributor

@tobiasholenstein tobiasholenstein commented Sep 9, 2021

Added #ifndef _LP64 guard to the MachCallNode::return_value_is_used() method in src/hotspot/share/opto/machnode.* because it is only used for 32-bit x86.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264517: C2: make MachCallNode::return_value_is_used() only available for x86

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5435/head:pull/5435
$ git checkout pull/5435

Update a local copy of the PR:
$ git checkout pull/5435
$ git pull https://git.openjdk.java.net/jdk pull/5435/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5435

View PR using the GUI difftool:
$ git pr show -t 5435

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5435.diff

@bridgekeeper bridgekeeper bot added the oca label Sep 9, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 9, 2021

Hi @tobiasholenstein, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user tobiasholenstein" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

@tobiasholenstein The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@tobiasholenstein
Copy link
Contributor Author

@tobiasholenstein tobiasholenstein commented Sep 9, 2021

/covered

@bridgekeeper bridgekeeper bot removed the oca label Sep 9, 2021
@openjdk openjdk bot added the rfr label Sep 9, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 9, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good

@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

@tobiasholenstein This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264517: C2: make MachCallNode::return_value_is_used() only available for x86

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

  • 70c9e02: 8272148: JDesktopPane:getComponentCount() returns one extra than expected with GTKLookAndFeel
  • 08f0be8: 8272608: java_lang_System::allow_security_manager() doesn't set its initialization flag
  • 2e321dc: 8273528: Avoid ByteArrayOutputStream.toByteArray when converting stream to String
  • 54dee13: 8273188: java/lang/instrument/BootClassPath/BootClassPathTest.sh fails with "FATAL ERROR in native method: processing of -javaagent failed, processJavaStart failed"
  • 4020a60: 8273550: Replace os::cgc_thread/pgc_thread with os::gc_thread
  • 185eaca: 8273545: Remove Thread::is_GC_task_thread()
  • dd1209e: 8268885: duplicate checkcast when destination type is not first type of intersection type
  • ef4a532: 8263773: Reenable German localization for builds at Oracle
  • 96614da: 8272903: Missing license header in ArenaAllocator.java
  • e3bda63: 8273489: Zero: Handle UseHeavyMonitors on all monitorenter paths
  • ... and 27 more: https://git.openjdk.java.net/jdk/compare/faa942c8ba8ad778b6be20ff6d98a5040a9079e9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 9, 2021
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me too.

@tobiasholenstein
Copy link
Contributor Author

@tobiasholenstein tobiasholenstein commented Sep 10, 2021

/integrate

@openjdk openjdk bot added the sponsor label Sep 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

@tobiasholenstein
Your change (at version fb614c0) is now ready to be sponsored by a Committer.

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Sep 10, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

Going to push as commit 792281d.
Since your change was applied there have been 37 commits pushed to the master branch:

  • 70c9e02: 8272148: JDesktopPane:getComponentCount() returns one extra than expected with GTKLookAndFeel
  • 08f0be8: 8272608: java_lang_System::allow_security_manager() doesn't set its initialization flag
  • 2e321dc: 8273528: Avoid ByteArrayOutputStream.toByteArray when converting stream to String
  • 54dee13: 8273188: java/lang/instrument/BootClassPath/BootClassPathTest.sh fails with "FATAL ERROR in native method: processing of -javaagent failed, processJavaStart failed"
  • 4020a60: 8273550: Replace os::cgc_thread/pgc_thread with os::gc_thread
  • 185eaca: 8273545: Remove Thread::is_GC_task_thread()
  • dd1209e: 8268885: duplicate checkcast when destination type is not first type of intersection type
  • ef4a532: 8263773: Reenable German localization for builds at Oracle
  • 96614da: 8272903: Missing license header in ArenaAllocator.java
  • e3bda63: 8273489: Zero: Handle UseHeavyMonitors on all monitorenter paths
  • ... and 27 more: https://git.openjdk.java.net/jdk/compare/faa942c8ba8ad778b6be20ff6d98a5040a9079e9...master

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

@TobiHartmann @tobiasholenstein Pushed as commit 792281d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants