8273539: [PPC64] gtest build error after JDK-8264207

[TheRealMDoerr]

macroAssembler.inline.hpp needs to be included to fix the build. Definition of e.g. nop() is not visible otherwise. See JBS bug for build error message.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8273539: [PPC64] gtest build error after JDK-8264207

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5438/head:pull/5438
$ git checkout pull/5438

Update a local copy of the PR:
$ git checkout pull/5438
$ git pull https://git.openjdk.java.net/jdk pull/5438/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5438

View PR using the GUI difftool:
$ git pr show -t 5438

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5438.diff

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheRealMDoerr The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (74127076)

[shipilev]

Looks good and trivial. (My CIs are also failing for two days now, but I only noticed now...)

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273539: [PPC64] gtest build error after JDK-8264207

Reviewed-by: shade, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

• aa93111: 8273483: Zero: Clear pending JNI exception check in native method handler
• 8c16f48: 8273487: Zero: Handle "zero" variant in runtime tests
• dc33bd8: 8273315: Parallelize and increase timeouts for java/foreign/TestMatrix.java test
• 5b1dfe4: 8273439: Fix G1CollectedHeap includes and forward declarations
• 6eba443: 8273387: remove some unreferenced gtk-related functions
• 5df2648: 8273218: G1: Rename g1EvacuationInfo to g1EvacInfo
• 12f0b77: 8273516: ProblemList compiler/c2/Test7179138_1.java in -Xcomp mode on win-X64
• 7fd6b0b: 8273242: (test) Refactor to use TestNG for RuntimeTests ExecCommand tests
• a5e4def: 8265489: Stress test times out because of long ObjectSynchronizer::monitors_iterate(...) operation
• 9b5991e: 8273451: Remove unreachable return in mutexLocker::wait
• ... and 30 more: https://git.openjdk.java.net/jdk/compare/70157c78a838126bb29c91a410d9158763bfa2ad...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

Good and trivial.

[TheRealMDoerr]

Thanks for the reviews! I'm just integrating it to get the build working again.
/integrate

[openjdk]

Going to push as commit f6cc173.
Since your change was applied there have been 42 commits pushed to the master branch:

• 9690df7: 8273476: G1: refine G1CollectedHeap::par_iterate_regions_array_part_from
• 00e059d: 8133686: HttpURLConnection.getHeaderFields and URLConnection.getRequestProperties methods return field values in reverse order
• aa93111: 8273483: Zero: Clear pending JNI exception check in native method handler
• 8c16f48: 8273487: Zero: Handle "zero" variant in runtime tests
• dc33bd8: 8273315: Parallelize and increase timeouts for java/foreign/TestMatrix.java test
• 5b1dfe4: 8273439: Fix G1CollectedHeap includes and forward declarations
• 6eba443: 8273387: remove some unreferenced gtk-related functions
• 5df2648: 8273218: G1: Rename g1EvacuationInfo to g1EvacInfo
• 12f0b77: 8273516: ProblemList compiler/c2/Test7179138_1.java in -Xcomp mode on win-X64
• 7fd6b0b: 8273242: (test) Refactor to use TestNG for RuntimeTests ExecCommand tests
• ... and 32 more: https://git.openjdk.java.net/jdk/compare/70157c78a838126bb29c91a410d9158763bfa2ad...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit f6cc173.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.