Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273545: Remove Thread::is_GC_task_thread() #5442

Closed

Conversation

pliden
Copy link
Contributor

@pliden pliden commented Sep 9, 2021

I propose we remove Thread::is_GC_task_thread(). It's used only in two places (one in ZGC, and one assert in ParallelGC), and those two uses can be replaced by calls to is_Worker_thread() instead. Removing is_GC_task_thread() also allows us to clean out some stuff from WorkGang/GangWorker.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5442/head:pull/5442
$ git checkout pull/5442

Update a local copy of the PR:
$ git checkout pull/5442
$ git pull https://git.openjdk.java.net/jdk pull/5442/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5442

View PR using the GUI difftool:
$ git pr show -t 5442

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5442.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 9, 2021

👋 Welcome back pliden! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

@pliden The following labels will be automatically applied to this pull request:

  • hotspot
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot shenandoah labels Sep 9, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 9, 2021

Webrevs

stefank
stefank approved these changes Sep 9, 2021
Copy link
Member

@stefank stefank left a comment

Looks good

@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

@pliden This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273545: Remove Thread::is_GC_task_thread()

Reviewed-by: stefank, coleenp, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 4866eaa: 8273409: Receiver type narrowed by CCP does not always trigger post-parse call devirtualization
  • 5ca26cb: 8273433: Enable parallelism in vmTestbase_nsk_sysdict tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 9, 2021
coleenp
coleenp approved these changes Sep 9, 2021
Copy link
Contributor

@coleenp coleenp left a comment

Looks good to me. So Worker threads could always do operations during a safepoint? They're NamedThreads so they can run across safepoints? Thanks.

@pliden
Copy link
Contributor Author

@pliden pliden commented Sep 9, 2021

Looks good to me. So Worker threads could always do operations during a safepoint? They're NamedThreads so they can run across safepoints? Thanks.

What a worker thread can and can not do with regards to safepoints depends on the GC, and what WorkGang instance in that GC. In other words, there's no strong connection between the two that is true for all GCs and all WorkGangs.

Copy link
Contributor

@shipilev shipilev left a comment

Looks fine.

@pliden
Copy link
Contributor Author

@pliden pliden commented Sep 9, 2021

Thanks all for reviewing!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

Going to push as commit 185eaca.
Since your change was applied there have been 7 commits pushed to the master branch:

  • dd1209e: 8268885: duplicate checkcast when destination type is not first type of intersection type
  • ef4a532: 8263773: Reenable German localization for builds at Oracle
  • 96614da: 8272903: Missing license header in ArenaAllocator.java
  • e3bda63: 8273489: Zero: Handle UseHeavyMonitors on all monitorenter paths
  • c81690d: 8273498: compiler/c2/Test7179138_1.java timed out
  • 4866eaa: 8273409: Receiver type narrowed by CCP does not always trigger post-parse call devirtualization
  • 5ca26cb: 8273433: Enable parallelism in vmTestbase_nsk_sysdict tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

@pliden Pushed as commit 185eaca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pliden pliden deleted the 8273545_remove_is_gc_task_thread branch Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot integrated shenandoah
4 participants