JDK-8273541: Cleaner Thread creates with normal priority instead of MAX_PRIORITY - 2 #5443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
Please review this fix for JDK-8273541. It seems that change 1 accidentally modified Thread.MAX_PRIORITY to Thread.MIN_PRIORITY. As Thread.MIN_PRIORITY - 2 is negative and because of the check 2, the thread priority is not set. Changing this back to Thread.MAX_PRIORITY should fix the problem. I tried this patch locally and it seems to fix the issue for me.
Regards,
Kartik
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5443/head:pull/5443
$ git checkout pull/5443
Update a local copy of the PR:
$ git checkout pull/5443
$ git pull https://git.openjdk.java.net/jdk pull/5443/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5443
View PR using the GUI difftool:
$ git pr show -t 5443
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5443.diff