Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8273541: Cleaner Thread creates with normal priority instead of MAX_PRIORITY - 2 #5443

Closed
wants to merge 1 commit into from

Conversation

amCap1712
Copy link
Contributor

@amCap1712 amCap1712 commented Sep 9, 2021

Hi all!

Please review this fix for JDK-8273541. It seems that change 1 accidentally modified Thread.MAX_PRIORITY to Thread.MIN_PRIORITY. As Thread.MIN_PRIORITY - 2 is negative and because of the check 2, the thread priority is not set. Changing this back to Thread.MAX_PRIORITY should fix the problem. I tried this patch locally and it seems to fix the issue for me.

Regards,
Kartik


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273541: Cleaner Thread creates with normal priority instead of MAX_PRIORITY - 2

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5443/head:pull/5443
$ git checkout pull/5443

Update a local copy of the PR:
$ git checkout pull/5443
$ git pull https://git.openjdk.java.net/jdk pull/5443/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5443

View PR using the GUI difftool:
$ git pr show -t 5443

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5443.diff

…AX_PRIORITY - 2

Revert accidental change which replaced Thread.MAX_PRIORITY with
Thread.MIN_PRIORITY.
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 9, 2021

👋 Welcome back amCap1712! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@amCap1712
Copy link
Contributor Author

Closing as fix is already open at #5439

@amCap1712 amCap1712 closed this Sep 9, 2021
@amCap1712 amCap1712 deleted the cleaner-priority branch September 9, 2021 13:04
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 9, 2021
@openjdk
Copy link

openjdk bot commented Sep 9, 2021

@amCap1712 The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant