8273456: Do not hold ttyLock around stack walking #5445

coleenp · 2021-09-09T14:54:01Z

This change moves the tty rank back down to near access, and prints stack traces to stringStream to avoid holding the tty lock while trying to take the stackwatermark lock.
Tested with tier1-8 (7,8 still in progress but no failures so far).

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8273456: Do not hold ttyLock around stack walking

Reviewers

David Holmes (@dholmes-ora - Reviewer)
Erik Österlund (@fisk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5445/head:pull/5445
$ git checkout pull/5445

Update a local copy of the PR:
$ git checkout pull/5445
$ git pull https://git.openjdk.java.net/jdk pull/5445/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5445

View PR using the GUI difftool:
$ git pr show -t 5445

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5445.diff

coleenp · 2021-09-09T14:54:53Z

src/hotspot/share/runtime/deoptimization.cpp

@@ -210,7 +244,6 @@ static bool rematerialize_objects(JavaThread* thread, int exec_mode, CompiledMet
    return_value = Handle(thread, result);
    assert(Universe::heap()->is_in_or_null(result), "must be heap pointer");
    if (TraceDeoptimization) {
-      ttyLocker ttyl;


The change also removes obvious places where ttyLocker isn't needed.

bridgekeeper · 2021-09-09T14:55:27Z

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-09-09T14:57:19Z

@coleenp The following label will be automatically applied to this pull request:

hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-09-09T15:02:15Z

Webrevs

00: Full (be896d74)

dholmes-ora

Hi Coleen,

My only minor concern with these changes is that we lose information if there is a crash during any of these logging loops. Before you would (should?) see how far we got before a crash, but now there will not be any indication of that. But that is not the primary intention of this logging so I think the changes are okay.

Thanks,
David

openjdk · 2021-09-09T23:24:47Z

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273456: Do not hold ttyLock around stack walking

Reviewed-by: dholmes, eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

695b434: Merge
4afbcaf: 8273592: Backout JDK-8271868
a37254c: 8271868: Warn user when using mac-sign option with unsigned app-image.
c464f09: 8273402: Use derived NamingExceptions in com.sun.jndi.ldap.Connection#readReply
4e6de5f: 8273541: Cleaner Thread creates with normal priority instead of MAX_PRIORITY - 2
c1e39fa: 8273482: Remove "foreground work" concept from WorkGang
2eaf374: 8272698: LoadNode::pin is unused
792281d: 8264517: C2: make MachCallNode::return_value_is_used() only available for x86
70c9e02: 8272148: JDesktopPane:getComponentCount() returns one extra than expected with GTKLookAndFeel
08f0be8: 8272608: java_lang_System::allow_security_manager() doesn't set its initialization flag
... and 8 more: https://git.openjdk.java.net/jdk/compare/c81690d7166c32caff6ef3a55fe9b157049e2b56...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

coleenp · 2021-09-10T01:38:40Z

I guess if you crashed you could look at st in the debugger. Thanks for the review!

fisk

Looks good.

coleenp · 2021-09-10T14:53:26Z

Thanks Erik!
/integrate

openjdk · 2021-09-10T14:54:57Z

Going to push as commit 461a467.
Since your change was applied there have been 18 commits pushed to the master branch:

695b434: Merge
4afbcaf: 8273592: Backout JDK-8271868
a37254c: 8271868: Warn user when using mac-sign option with unsigned app-image.
c464f09: 8273402: Use derived NamingExceptions in com.sun.jndi.ldap.Connection#readReply
4e6de5f: 8273541: Cleaner Thread creates with normal priority instead of MAX_PRIORITY - 2
c1e39fa: 8273482: Remove "foreground work" concept from WorkGang
2eaf374: 8272698: LoadNode::pin is unused
792281d: 8264517: C2: make MachCallNode::return_value_is_used() only available for x86
70c9e02: 8272148: JDesktopPane:getComponentCount() returns one extra than expected with GTKLookAndFeel
08f0be8: 8272608: java_lang_System::allow_security_manager() doesn't set its initialization flag
... and 8 more: https://git.openjdk.java.net/jdk/compare/c81690d7166c32caff6ef3a55fe9b157049e2b56...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-09-10T14:55:11Z

@coleenp Pushed as commit 461a467.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8273456: Do not hold ttyLock around stack walking

be896d7

coleenp commented Sep 9, 2021

View reviewed changes

openjdk bot added the rfr Pull request is ready for review label Sep 9, 2021

openjdk bot added the hotspot hotspot-dev@openjdk.org label Sep 9, 2021

dholmes-ora approved these changes Sep 9, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 9, 2021

fisk approved these changes Sep 10, 2021

View reviewed changes

openjdk bot closed this Sep 10, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 10, 2021

coleenp deleted the tty branch September 10, 2021 14:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8273456: Do not hold ttyLock around stack walking #5445

8273456: Do not hold ttyLock around stack walking #5445

coleenp commented Sep 9, 2021 •

edited by openjdk bot

Loading

coleenp Sep 9, 2021

bridgekeeper bot commented Sep 9, 2021

openjdk bot commented Sep 9, 2021

mlbridge bot commented Sep 9, 2021

dholmes-ora left a comment

openjdk bot commented Sep 9, 2021 •

edited

Loading

coleenp commented Sep 10, 2021

fisk left a comment

coleenp commented Sep 10, 2021

openjdk bot commented Sep 10, 2021

openjdk bot commented Sep 10, 2021

8273456: Do not hold ttyLock around stack walking #5445

8273456: Do not hold ttyLock around stack walking #5445

Conversation

coleenp commented Sep 9, 2021 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

coleenp Sep 9, 2021

Choose a reason for hiding this comment

bridgekeeper bot commented Sep 9, 2021

openjdk bot commented Sep 9, 2021

mlbridge bot commented Sep 9, 2021

Webrevs

dholmes-ora left a comment

Choose a reason for hiding this comment

openjdk bot commented Sep 9, 2021 • edited Loading

coleenp commented Sep 10, 2021

fisk left a comment

Choose a reason for hiding this comment

coleenp commented Sep 10, 2021

openjdk bot commented Sep 10, 2021

openjdk bot commented Sep 10, 2021

coleenp commented Sep 9, 2021 •

edited by openjdk bot

Loading

openjdk bot commented Sep 9, 2021 •

edited

Loading