8254166: Zero: return-type warning in zeroInterpreter_zero.cpp

[shipilev]

This breaks 11u without disabled warnings as errors, but the issue exists in head JDK as well. Might as well fix it everywhere.

Testing:

• Linux ARM32 Zero build on HEAD JDK
• Linux ARM32 Zero build on 11u

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8254166: Zero: return-type warning in zeroInterpreter_zero.cpp

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer) ⚠️ Review applies to 95d6243

Download

$ git fetch https://git.openjdk.java.net/jdk pull/545/head:pull/545
$ git checkout pull/545

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (2ab022f)
• 01: Full - Incremental (95d6243)
• 00: Full (b5167bd)

[jerboaa]

Looks OK to me. I'd suggest adding a comment as the return after ShouldNotReachHere() looks odd otherwise.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254166: Zero: return-type warning in zeroInterpreter_zero.cpp

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jerboaa]

Looks fine.

[shipilev]

/integrate

[openjdk]

@shipilev Since your change was applied there has been 1 commit pushed to the master branch:

• 894ec76: 8254027: gc/g1/TestHumongousConcurrentStartUndo.java failed with "'Concurrent Mark Cycle' missing from stdout/stderr"

Your commit was automatically rebased without conflicts.

Pushed as commit 7952c06.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.