Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254166: Zero: return-type warning in zeroInterpreter_zero.cpp #545

Closed

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Oct 7, 2020

This breaks 11u without disabled warnings as errors, but the issue exists in head JDK as well. Might as well fix it everywhere.

Testing:

  • Linux ARM32 Zero build on HEAD JDK
  • Linux ARM32 Zero build on 11u

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8254166: Zero: return-type warning in zeroInterpreter_zero.cpp

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/545/head:pull/545
$ git checkout pull/545

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 7, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 7, 2020
@openjdk
Copy link

openjdk bot commented Oct 7, 2020

@shipilev The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Oct 7, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 7, 2020

Webrevs

jerboaa
jerboaa approved these changes Oct 7, 2020
Copy link
Contributor

@jerboaa jerboaa left a comment

Looks OK to me. I'd suggest adding a comment as the return after ShouldNotReachHere() looks odd otherwise.

src/hotspot/cpu/zero/zeroInterpreter_zero.cpp Outdated Show resolved Hide resolved
@openjdk
Copy link

openjdk bot commented Oct 7, 2020

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254166: Zero: return-type warning in zeroInterpreter_zero.cpp

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 7, 2020
jerboaa
jerboaa approved these changes Oct 7, 2020
Copy link
Contributor

@jerboaa jerboaa left a comment

Looks fine.

@shipilev
Copy link
Contributor Author

shipilev commented Oct 8, 2020

/integrate

@openjdk openjdk bot closed this Oct 8, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 8, 2020
@openjdk
Copy link

openjdk bot commented Oct 8, 2020

@shipilev Since your change was applied there has been 1 commit pushed to the master branch:

  • 894ec76: 8254027: gc/g1/TestHumongousConcurrentStartUndo.java failed with "'Concurrent Mark Cycle' missing from stdout/stderr"

Your commit was automatically rebased without conflicts.

Pushed as commit 7952c06.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8254166-zero-narrow-return branch Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot integrated
2 participants