New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8273497: building.md should link to both md and html #5451
Conversation
|
@magicus This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 44 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on. Looks good to me.
/integrate |
Going to push as commit 5bfd043.
Your commit was automatically rebased without conflicts. |
The building.md (and the generated building.html) should link to both the markdown and the html version of the test documentation.
This is a replacement PR for https://git.openjdk.java.net/jdk/pull/5417, since I'm taking over the bug.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5451/head:pull/5451
$ git checkout pull/5451
Update a local copy of the PR:
$ git checkout pull/5451
$ git pull https://git.openjdk.java.net/jdk pull/5451/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5451
View PR using the GUI difftool:
$ git pr show -t 5451
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5451.diff