8254173: Add Zero, Minimal hotspot targets to submit workflow

[shipilev]

Zero VM and Minimal VM builds are routinely discovering the problems with internal Hotspot dependencies. Mostly because they turn off the whole lot of VM features, and every path that is not guarded by a feature #ifdef or build file list fails.

It would be good to add Zero and Minimal targets to submit workflow.

It seems to add two ~9 minute stages, compared to ~17 minute stage for building no-pch hotspot, and ~33 minutes for full JDK.

Attention @rwestberg.

Testing:

• GH workflow still works; see latest run

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x64	Windows x64	macOS x64
Build	⏳ (5/5 running)	⏳ (2/2 running)	⏳ (2/2 running)

Issue

• JDK-8254173: Add Zero, Minimal hotspot targets to submit workflow

Reviewers

• Erik Joelsson (@erikj79 - Reviewer) ⚠️ Review applies to 7e3e6ad
• Robin Westberg (@rwestberg - Committer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/546/head:pull/546
$ git checkout pull/546

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (e23b7b3)
• 01: Full - Incremental (7e3e6ad)
• 00: Full (e05c93d)

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254173: Add Zero, Minimal hotspot targets to submit workflow

Reviewed-by: erikj, rwestberg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• e1187c4: 8248262: Wrong link target in ModuleDescriptor#isAutomatic's API documentation
• 9cdfd0f: 8254096: remove jdk.test.lib.Utils::getMandatoryProperty(String) method
• d1e94ee: 8253909: Implement detailed map file for CDS
• 7733a0e: 8254182: remove Utils.tryFindJvmPid/waitForJvmPid
• 4e5ef30: 8254104: MethodCounters must exist before nmethod is installed
• fd0cb98: 8253901: ARM32: SIGSEGV during monitorexit due to incorrect register use (after JDK-8253540)
• abe2593: 8232092: (fs) Files::isWritable returns false on a writeable root directory (win)
• 5a9bd41: 8254102: use ProcessHandle::pid instead of ManagementFactory::getRuntimeMXBean to get pid in tests
• 38159d5: 8253876: jdk/test/lib/hexdump/ASN1FormatterTest.java fails with "AssertionError: Lines expected [126] but found [202]"
• db3053d: 8067127: Tags cleanup
• ... and 5 more: https://git.openjdk.java.net/jdk/compare/9543d7607bcb917811ef49c568c05459aedcd297...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[rwestberg]

Looks good to me! Adding a few additional shorter build shouldn't increase the total runtime, as the test execution waits for all builds to be done, so we are limited by the full builds anyway.

One minor comment, perhaps rearrange the description a bit of these new flavors with the differentiating parts first. GitHub cuts them short in the overview list (see the list on the left at https://github.com/shipilev/jdk/actions/runs/293805791 for an example) so you can't currently tell which one is which in the overview without clicking on them.

[rwestberg]

Looks good, thanks for fixing!

[shipilev]

/integrate

[openjdk]

@shipilev Since your change was applied there have been 15 commits pushed to the master branch:

• e1187c4: 8248262: Wrong link target in ModuleDescriptor#isAutomatic's API documentation
• 9cdfd0f: 8254096: remove jdk.test.lib.Utils::getMandatoryProperty(String) method
• d1e94ee: 8253909: Implement detailed map file for CDS
• 7733a0e: 8254182: remove Utils.tryFindJvmPid/waitForJvmPid
• 4e5ef30: 8254104: MethodCounters must exist before nmethod is installed
• fd0cb98: 8253901: ARM32: SIGSEGV during monitorexit due to incorrect register use (after JDK-8253540)
• abe2593: 8232092: (fs) Files::isWritable returns false on a writeable root directory (win)
• 5a9bd41: 8254102: use ProcessHandle::pid instead of ManagementFactory::getRuntimeMXBean to get pid in tests
• 38159d5: 8253876: jdk/test/lib/hexdump/ASN1FormatterTest.java fails with "AssertionError: Lines expected [126] but found [202]"
• db3053d: 8067127: Tags cleanup
• ... and 5 more: https://git.openjdk.java.net/jdk/compare/9543d7607bcb917811ef49c568c05459aedcd297...master

Your commit was automatically rebased without conflicts.

Pushed as commit bc23690.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.