New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian #5462
Conversation
|
@theaoqi This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@alexeysemenyukoracle, @andyherrick) but any other Committer may sponsor as well.
|
/contributor add Sun Xu sunxu01@loongson.cn |
@theaoqi |
/integrate |
@alexeysemenyukoracle Only the author (@theaoqi) is allowed to issue the |
/integrate |
Sorry, I issued the "integrate" command as I got confused with the "contributor" comment. |
Thanks for your review, @alexeysemenyukoracle ! I have typed "/integrate", but I am not sure if this needs a second reviewer or should wait for a longer time. |
/sponsor |
Going to push as commit f189dff.
Your commit was automatically rebased without conflicts. |
@DamonFool @theaoqi Pushed as commit f189dff. |
A similar issue on Ubuntu has been fixed by JDK-8238953. However, tools/jpackage tests do not work on Debian Linux or other apt-based Linux, when rpm package is installed. This issue proposes a general fix for apt-based Linux.
Progress
Issue
Reviewers
Contributors
<sunxu01@loongson.cn>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5462/head:pull/5462
$ git checkout pull/5462
Update a local copy of the PR:
$ git checkout pull/5462
$ git pull https://git.openjdk.java.net/jdk pull/5462/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5462
View PR using the GUI difftool:
$ git pr show -t 5462
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5462.diff