Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian #5462

Closed
wants to merge 2 commits into from

Conversation

@theaoqi
Copy link
Member

@theaoqi theaoqi commented Sep 10, 2021

A similar issue on Ubuntu has been fixed by JDK-8238953. However, tools/jpackage tests do not work on Debian Linux or other apt-based Linux, when rpm package is installed. This issue proposes a general fix for apt-based Linux.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian

Reviewers

Contributors

  • Sun Xu <sunxu01@loongson.cn>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5462/head:pull/5462
$ git checkout pull/5462

Update a local copy of the PR:
$ git checkout pull/5462
$ git pull https://git.openjdk.java.net/jdk pull/5462/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5462

View PR using the GUI difftool:
$ git pr show -t 5462

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5462.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 10, 2021

👋 Welcome back aoqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

@theaoqi The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the core-libs label Sep 10, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 10, 2021

Webrevs

Loading

@theaoqi theaoqi changed the title 8273595: tools/jpackage tests do not work on apt-based Linux Distros like Debian 8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian Sep 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

@theaoqi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian

Co-authored-by: Sun Xu <sunxu01@loongson.cn>
Reviewed-by: asemenyuk, herrick

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • ec9d1be: 8273194: Document the two possible cases when Lookup::ensureInitialized returns
  • 81d2ace: 8273369: Computing micros between two instants unexpectedly overflows for some cases
  • efe3ed1: 8273358: macOS Monterey does not have the font Times needed by Serif
  • e58c12e: 8273512: Fix the copyright header of x86 macroAssembler files
  • 461a467: 8273456: Do not hold ttyLock around stack walking
  • 695b434: Merge
  • 4afbcaf: 8273592: Backout JDK-8271868
  • a37254c: 8271868: Warn user when using mac-sign option with unsigned app-image.
  • c464f09: 8273402: Use derived NamingExceptions in com.sun.jndi.ldap.Connection#readReply
  • 4e6de5f: 8273541: Cleaner Thread creates with normal priority instead of MAX_PRIORITY - 2

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@alexeysemenyukoracle, @andyherrick) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Sep 10, 2021
@theaoqi
Copy link
Member Author

@theaoqi theaoqi commented Sep 10, 2021

/contributor add Sun Xu sunxu01@loongson.cn

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

@theaoqi
Contributor Sun Xu <sunxu01@loongson.cn> successfully added.

Loading

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Sep 10, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

@alexeysemenyukoracle Only the author (@theaoqi) is allowed to issue the integrate command.

Loading

@theaoqi
Copy link
Member Author

@theaoqi theaoqi commented Sep 10, 2021

/integrate

Loading

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Sep 10, 2021

Sorry, I issued the "integrate" command as I got confused with the "contributor" comment.

Loading

@openjdk openjdk bot added the sponsor label Sep 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

@theaoqi
Your change (at version e4ad900) is now ready to be sponsored by a Committer.

Loading

@theaoqi
Copy link
Member Author

@theaoqi theaoqi commented Sep 10, 2021

Thanks for your review, @alexeysemenyukoracle ! I have typed "/integrate", but I am not sure if this needs a second reviewer or should wait for a longer time.

Loading

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Sep 10, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

Going to push as commit f189dff.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 922e86f: 8273522: Rename test property vm.cds.archived.java.heap to vm.cds.write.archived.java.heap
  • f42b927: 8273609: Fix trivial doc typos in the compiler area
  • e4cd209: 8273611: Remove unused ProfilePrint_lock
  • f690a01: 8273278: Support XSLT on GraalVM Native Image--deterministic bytecode generation in XSLT
  • 5e1df2c: 8273162: AbstractSplittableWithBrineGenerator does not create a random salt
  • d4177a9: 8273351: bad tag in jdk.random module-info.java
  • ec9d1be: 8273194: Document the two possible cases when Lookup::ensureInitialized returns
  • 81d2ace: 8273369: Computing micros between two instants unexpectedly overflows for some cases
  • efe3ed1: 8273358: macOS Monterey does not have the font Times needed by Serif
  • e58c12e: 8273512: Fix the copyright header of x86 macroAssembler files
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/c1e39faaa99ee62ff626ffec9f978ed0f8ffaca1...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

@DamonFool @theaoqi Pushed as commit f189dff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@theaoqi theaoqi deleted the 8273595 branch Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants