8254175: Build no-pch configuration in debug mode for submit checks

[shipilev]

no-pch configuration is supposed to expose missing include dependencies. But currently it runs with default (release) bits, which misses symbols hidden in debug code. We should consider building it in debug mode.

Attention @rwestberg.

Testing:

• GH workflow still works, see the builds in the latest run

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x64	Windows x64	macOS x64
Build	✔️ (3/3 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

• JDK-8254175: Build no-pch configuration in debug mode for submit checks

Reviewers

• Robin Westberg (@rwestberg - Committer)
• Erik Joelsson (@erikj79 - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/547/head:pull/547
$ git checkout pull/547

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (bf211c8)
• 00: Full (1855088)

[rwestberg]

Looks good to me! Just a similar comment as in #546, the name is a bit too long now, so perhaps just drop the "debug" from the description?

[rwestberg]

Looks good!

[shipilev]

/integrate

[openjdk]

@shipilev This PR has not yet been marked as ready for integration.

[shipilev]

@erikj79, can you take a look as well? Or maybe @dholmes-ora wants to chime in on the sanity of the change?

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254175: Build no-pch configuration in debug mode for submit checks

Reviewed-by: rwestberg, erikj, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

• b9873e1: 8253180: ZGC: Implementation of JEP 376: ZGC: Concurrent Thread-Stack Processing
• a2f6519: 8233685: Test tools/javac/modules/AddLimitMods.java fails
• 70be8c7: 8253965: Delete the outdated java.awt.PeerFixer class
• ced46b1: 8254190: [s390] interpreter misses exception check after calling monitorenter
• 5351ba6: 8254262: jdk.test.lib.Utils::createTemp* don't pass attrs
• 8c0d3d7: 8254195: java/nio/file/Files/SubstDrive.java failed with "AssertionError: expected [144951656448] but found [144951640064]"
• c2a5de6: 8253681: closed java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed
• d036dca: 8254103: Shenandoah: Move updating thread roots to concurrent phase
• 7e82ba1: 8254146: Avoid unnecessary volatile write on new AtomicBoolean(false)
• 6d13c76: 8253191: C2: Masked byte comparisons with large masks produce wrong result on x86
• ... and 25 more: https://git.openjdk.java.net/jdk/compare/9543d7607bcb917811ef49c568c05459aedcd297...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

This affects testing for everyone, so I would like someone from hotspot to chime in.

/label hotspot

[openjdk]

@shipilev
The hotspot label was successfully added.

[dholmes-ora]

Seems reasonable.

[shipilev]

/integrate

[openjdk]

@shipilev Since your change was applied there have been 35 commits pushed to the master branch:

• b9873e1: 8253180: ZGC: Implementation of JEP 376: ZGC: Concurrent Thread-Stack Processing
• a2f6519: 8233685: Test tools/javac/modules/AddLimitMods.java fails
• 70be8c7: 8253965: Delete the outdated java.awt.PeerFixer class
• ced46b1: 8254190: [s390] interpreter misses exception check after calling monitorenter
• 5351ba6: 8254262: jdk.test.lib.Utils::createTemp* don't pass attrs
• 8c0d3d7: 8254195: java/nio/file/Files/SubstDrive.java failed with "AssertionError: expected [144951656448] but found [144951640064]"
• c2a5de6: 8253681: closed java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed
• d036dca: 8254103: Shenandoah: Move updating thread roots to concurrent phase
• 7e82ba1: 8254146: Avoid unnecessary volatile write on new AtomicBoolean(false)
• 6d13c76: 8253191: C2: Masked byte comparisons with large masks produce wrong result on x86
• ... and 25 more: https://git.openjdk.java.net/jdk/compare/9543d7607bcb917811ef49c568c05459aedcd297...master

Your commit was automatically rebased without conflicts.

Pushed as commit 0230781.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.