Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273616: Fix trivial doc typos in the java.base module #5475

Closed
wants to merge 3 commits into from

Conversation

@pavelrappo
Copy link
Member

@pavelrappo pavelrappo commented Sep 10, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273616: Fix trivial doc typos in the java.base module

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5475/head:pull/5475
$ git checkout pull/5475

Update a local copy of the PR:
$ git checkout pull/5475
$ git pull https://git.openjdk.java.net/jdk pull/5475/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5475

View PR using the GUI difftool:
$ git pr show -t 5475

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5475.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 10, 2021

👋 Welcome back prappo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

@pavelrappo The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n
  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 10, 2021

Webrevs

rose00
rose00 approved these changes Sep 10, 2021
Copy link
Contributor

@rose00 rose00 left a comment

Approved, except for two changes commented above: the original "it need only force" is correct usage, and "it needs only force" is not good usage, but "it only needs to force" would be clearer and also correct.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

@pavelrappo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273616: Fix trivial doc typos in the java.base module

Reviewed-by: jrose, iris, lancea, dfuchs, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 4cfa230: 8273259: Character.getName doesn't follow Unicode spec for ideographs
  • f9b2507: 8271834: TestStringDeduplicationAgeThreshold intermittent failures on Shenandoah
  • 261cb44: 8273629: compiler/uncommontrap/TestDeoptOOM.java fails with release VMs
  • b0d0497: 8273584: TypeElement.getSuperclass crashes for a record TypeElement when j.l.Record is not available
  • 4efcd20: 8273478: [macos11] JTabbedPane selected and pressed tab is not legible
  • a73c06d: 8273021: C2: Improve Add and Xor ideal optimizations
  • 9f86082: 8273610: LogTestFixture::restore_config() should not restore options
  • 2ee1f96: 8273484: Cleanup unnecessary null comparison before instanceof check in java.naming
  • f189dff: 8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian
  • 922e86f: 8273522: Rename test property vm.cds.archived.java.heap to vm.cds.write.archived.java.heap
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/f690a01f1e5de4ace39aefad656cb7c99f9ec4e1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 10, 2021
@pavelrappo
Copy link
Member Author

@pavelrappo pavelrappo commented Sep 13, 2021

Thanks to those who reviewed this PR. Since I posted it, I've found three more occurrences of insure used in the sense of ensure: two in the java.io.Object*Stream area and one in the java.util.Currency class. I decided to fix those in this PR, which now needs to be (re)reviewed. Thanks!

There are more occurrences of insure, which I didn't touch. Some of them are in java.sql, java.sql.rowset and java.desktop. In the latter, insure even crept into method names.

@pavelrappo pavelrappo requested a review from irisclark Sep 13, 2021
dfuch
dfuch approved these changes Sep 13, 2021
Copy link
Member

@dfuch dfuch left a comment

LGTM

rose00
rose00 approved these changes Sep 13, 2021
@pavelrappo
Copy link
Member Author

@pavelrappo pavelrappo commented Sep 13, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 13, 2021

Going to push as commit b4b1210.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 7c26ddb: 8195809: [TESTBUG] jps and jcmd -l support for containers is not tested
  • 4cfa230: 8273259: Character.getName doesn't follow Unicode spec for ideographs
  • f9b2507: 8271834: TestStringDeduplicationAgeThreshold intermittent failures on Shenandoah
  • 261cb44: 8273629: compiler/uncommontrap/TestDeoptOOM.java fails with release VMs
  • b0d0497: 8273584: TypeElement.getSuperclass crashes for a record TypeElement when j.l.Record is not available
  • 4efcd20: 8273478: [macos11] JTabbedPane selected and pressed tab is not legible
  • a73c06d: 8273021: C2: Improve Add and Xor ideal optimizations
  • 9f86082: 8273610: LogTestFixture::restore_config() should not restore options
  • 2ee1f96: 8273484: Cleanup unnecessary null comparison before instanceof check in java.naming
  • f189dff: 8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian
  • ... and 3 more: https://git.openjdk.java.net/jdk/compare/f690a01f1e5de4ace39aefad656cb7c99f9ec4e1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 13, 2021

@pavelrappo Pushed as commit b4b1210.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment