Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273613: JFR: RemoteRecordingStream::start() blocks close() #5476

Closed
wants to merge 2 commits into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Sep 10, 2021

Hi,

Could I please have a review of a bug fix of RemoteRecordingStream?

RemoteRecordingStream::start() method takes a lock, which blocks the close() method if invoked from another thread.

Testing: jdk/jdk/jfr

Thanks
Erik


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273613: JFR: RemoteRecordingStream::start() blocks close()

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5476/head:pull/5476
$ git checkout pull/5476

Update a local copy of the PR:
$ git checkout pull/5476
$ git pull https://git.openjdk.java.net/jdk pull/5476/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5476

View PR using the GUI difftool:
$ git pr show -t 5476

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5476.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 10, 2021

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr label Sep 10, 2021
@egahlin egahlin marked this pull request as ready for review Sep 12, 2021
@openjdk openjdk bot added the rfr label Sep 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 12, 2021

Webrevs

Copy link

@mgronlun mgronlun left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 13, 2021

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273613: JFR: RemoteRecordingStream::start() blocks close()

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • b0d0497: 8273584: TypeElement.getSuperclass crashes for a record TypeElement when j.l.Record is not available
  • 4efcd20: 8273478: [macos11] JTabbedPane selected and pressed tab is not legible
  • a73c06d: 8273021: C2: Improve Add and Xor ideal optimizations
  • 9f86082: 8273610: LogTestFixture::restore_config() should not restore options
  • 2ee1f96: 8273484: Cleanup unnecessary null comparison before instanceof check in java.naming
  • f189dff: 8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian
  • 922e86f: 8273522: Rename test property vm.cds.archived.java.heap to vm.cds.write.archived.java.heap

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 13, 2021
@egahlin
Copy link
Member Author

@egahlin egahlin commented Sep 20, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2021

Going to push as commit d16bf04.
Since your change was applied there have been 101 commits pushed to the master branch:

  • 7ce60c6: 8273651: JFR: onMetadata(), setStartTime(), setEndTime() lacks test coverage
  • 1bd11a7: 8273887: [macos] java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java timed out
  • ee3576a: 8256735: JFR: 'jfr' tool displays incorrect timestamps
  • 5fde4b6: 8273909: vmTestbase/nsk/jdi/Event/request/request001 can still fail with "ERROR: new event is not ThreadStartEvent"
  • 04891c9: 8273912: Add threadControl_dumpThread(jthread) function
  • 5c21c00: 8267163: Rename anonymous loader tests to hidden loader tests
  • b3b4b1c: 8273907: Cleanup redundant Math.max/min calls in DefaultHighlighter
  • a67f0f9: 8273505: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#default-cl crashed with SIGSEGV in MetaspaceShared::link_shared_classes
  • 26e5e9a: 8273654: JFR: Remove unused SecuritySupport.setAccessible(Field)
  • 4b3a4ff: 8273940: vmTestbase/vm/mlvm/meth/stress/gc/callSequencesDuringGC/Test.java crashes in full gc during VM exit
  • ... and 91 more: https://git.openjdk.java.net/jdk/compare/f42b92790a6977ff17869762cd90a58cddccb8be...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2021

@egahlin Pushed as commit d16bf04.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr integrated
2 participants