Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273651: JFR: onMetadata(), setStartTime(), setEndTime() lacks test coverage #5477

Closed
wants to merge 4 commits into from

Conversation

@egahlin
Copy link
Member

@egahlin egahlin commented Sep 10, 2021

Hi,

Could I have review of a test fix that increases the code coverage for methods in the jdk.management.jfr.RemoteRecordingStream class.

Testing: jdk/jdk/jfr/jmx/streaming/

Thanks
Erik


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273651: JFR: onMetadata(), setStartTime(), setEndTime() lacks test coverage

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5477/head:pull/5477
$ git checkout pull/5477

Update a local copy of the PR:
$ git checkout pull/5477
$ git pull https://git.openjdk.java.net/jdk pull/5477/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5477

View PR using the GUI difftool:
$ git pr show -t 5477

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5477.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 10, 2021

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 11, 2021

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-jfr label Sep 11, 2021
@egahlin egahlin changed the title JFR: Several methods in RemoteRecordingStream are not covered 8272943:JFR: Several methods in RemoteRecordingStream are not covered Sep 12, 2021
@egahlin egahlin changed the title 8272943:JFR: Several methods in RemoteRecordingStream are not covered 8272943: JFR: Several methods in RemoteRecordingStream are not covered Sep 12, 2021
@egahlin egahlin changed the title 8272943: JFR: Several methods in RemoteRecordingStream are not covered 8273651: JFR: onMetadata(), setStartTime(), setEndTime() lacks test coverage Sep 13, 2021
@egahlin egahlin marked this pull request as ready for review Sep 13, 2021
@openjdk openjdk bot added the rfr label Sep 13, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 13, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273651: JFR: onMetadata(), setStartTime(), setEndTime() lacks test coverage

Reviewed-by: mgronlun, mseledtsov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

  • e66bf47: 8273414: ResourceObj::operator delete should handle nullptr in debug builds
  • 16c3ad1: 8272574: C2: assert(false) failed: Bad graph detected in build_loop_late
  • e7ab372: 8273641: (bf) Buffer subclasses documentation contains template strings
  • 22a7191: 8273040: Turning off JpAllowDowngrades (or Upgrades)
  • 394ebc8: 8270553: Tests should not use (real, in-use, routable) 1.1.1.1 as dummy IP value
  • 0f31d0f: 8273373: Zero: Cannot invoke JVM in primordial threads on Zero
  • fe89dd3: 8271254: javac generates unreachable code when using empty semicolon statement
  • 8974b95: 8273730: WorkGangBarrierSync constructor unused
  • 1d3eb14: 8273635: Attempting to acquire lock StackWatermark_lock/9 out of order with lock tty_lock/3
  • 31667da: 8273491: java.util.spi.LocaleServiceProvider spec contains statement that is too strict
  • ... and 40 more: https://git.openjdk.java.net/jdk/compare/c1e39faaa99ee62ff626ffec9f978ed0f8ffaca1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 14, 2021
Copy link
Member

@mseledts mseledts left a comment

Looks good to me.

Loading

@egahlin
Copy link
Member Author

@egahlin egahlin commented Sep 20, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2021

Going to push as commit 7ce60c6.
Since your change was applied there have been 115 commits pushed to the master branch:

  • 1bd11a7: 8273887: [macos] java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java timed out
  • ee3576a: 8256735: JFR: 'jfr' tool displays incorrect timestamps
  • 5fde4b6: 8273909: vmTestbase/nsk/jdi/Event/request/request001 can still fail with "ERROR: new event is not ThreadStartEvent"
  • 04891c9: 8273912: Add threadControl_dumpThread(jthread) function
  • 5c21c00: 8267163: Rename anonymous loader tests to hidden loader tests
  • b3b4b1c: 8273907: Cleanup redundant Math.max/min calls in DefaultHighlighter
  • a67f0f9: 8273505: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#default-cl crashed with SIGSEGV in MetaspaceShared::link_shared_classes
  • 26e5e9a: 8273654: JFR: Remove unused SecuritySupport.setAccessible(Field)
  • 4b3a4ff: 8273940: vmTestbase/vm/mlvm/meth/stress/gc/callSequencesDuringGC/Test.java crashes in full gc during VM exit
  • dad5d27: 8272867: JFR: ManagementSupport.removeBefore() lost coverage
  • ... and 105 more: https://git.openjdk.java.net/jdk/compare/c1e39faaa99ee62ff626ffec9f978ed0f8ffaca1...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2021

@egahlin Pushed as commit 7ce60c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants