Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273629: compiler/uncommontrap/TestDeoptOOM.java fails with release VMs #5479

Closed
wants to merge 1 commit into from

Conversation

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Sep 11, 2021

Hi all,

The test fails since VM option 'LogCompilation' is diagnostic and must be enabled via -XX:+UnlockDiagnosticVMOptions.
So only -XX:+UnlockDiagnosticVMOptions is added to fix it.

Thanks.
Best regards,
Jie


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273629: compiler/uncommontrap/TestDeoptOOM.java fails with release VMs

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5479/head:pull/5479
$ git checkout pull/5479

Update a local copy of the PR:
$ git checkout pull/5479
$ git pull https://git.openjdk.java.net/jdk pull/5479/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5479

View PR using the GUI difftool:
$ git pr show -t 5479

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5479.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 11, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 11, 2021

@DamonFool The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 11, 2021

Webrevs

Loading

Copy link
Contributor

@shipilev shipilev left a comment

This looks fine to me.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 13, 2021

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273629: compiler/uncommontrap/TestDeoptOOM.java fails with release VMs

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • b0d0497: 8273584: TypeElement.getSuperclass crashes for a record TypeElement when j.l.Record is not available
  • 4efcd20: 8273478: [macos11] JTabbedPane selected and pressed tab is not legible
  • a73c06d: 8273021: C2: Improve Add and Xor ideal optimizations
  • 9f86082: 8273610: LogTestFixture::restore_config() should not restore options
  • 2ee1f96: 8273484: Cleanup unnecessary null comparison before instanceof check in java.naming

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 13, 2021
@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Sep 13, 2021

Thanks @shipilev .
/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 13, 2021

Going to push as commit 261cb44.
Since your change was applied there have been 5 commits pushed to the master branch:

  • b0d0497: 8273584: TypeElement.getSuperclass crashes for a record TypeElement when j.l.Record is not available
  • 4efcd20: 8273478: [macos11] JTabbedPane selected and pressed tab is not legible
  • a73c06d: 8273021: C2: Improve Add and Xor ideal optimizations
  • 9f86082: 8273610: LogTestFixture::restore_config() should not restore options
  • 2ee1f96: 8273484: Cleanup unnecessary null comparison before instanceof check in java.naming

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 13, 2021

@DamonFool Pushed as commit 261cb44.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@DamonFool DamonFool deleted the JDK-8273629 branch Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants