Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273654: JFR: Remove unused SecuritySupport.setAccessible(Field) #5484

Closed
wants to merge 1 commit into from

Conversation

@egahlin
Copy link
Member

@egahlin egahlin commented Sep 12, 2021

Hi,

Could I have a review of a fix that removes an unused method.

Testing: jdk/jdk/jfr

Thanks
Erik


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273654: JFR: Remove unused SecuritySupport.setAccessible(Field)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5484/head:pull/5484
$ git checkout pull/5484

Update a local copy of the PR:
$ git checkout pull/5484
$ git pull https://git.openjdk.java.net/jdk pull/5484/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5484

View PR using the GUI difftool:
$ git pr show -t 5484

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5484.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 12, 2021

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 12, 2021

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-jfr label Sep 12, 2021
@egahlin egahlin changed the title 8272941: JFR SecuritySupport.setAccessible(Field) is not covered by tests 8273654: JFR: Remove unused SecuritySupport.setAccessible(Field) Sep 13, 2021
@egahlin egahlin marked this pull request as ready for review Sep 13, 2021
@openjdk openjdk bot added the rfr label Sep 13, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 13, 2021

Webrevs

Loading

Copy link
Member

@mseledts mseledts left a comment

Looks good and trivial

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273654: JFR: Remove unused SecuritySupport.setAccessible(Field)

Reviewed-by: mseledtsov, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 8d73ee6: 8273471: Add foldmultilines to UL for stdout/err
  • c54a918: 8273691: Missing comma after 2021 in GraphemeTestAccessor.java copyright notice
  • 3d9dc8f: 8273430: Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark
  • 5095068: 8273675: Remove unused Universe::_verify_in_progress flag
  • fc0f854: 8246797: A convenient method to read OPTIONAL element
  • 6cf5079: 8273513: Make java.io.FilterInputStream specification more precise about overrides
  • b4b1210: 8273616: Fix trivial doc typos in the java.base module
  • 7c26ddb: 8195809: [TESTBUG] jps and jcmd -l support for containers is not tested
  • 4cfa230: 8273259: Character.getName doesn't follow Unicode spec for ideographs
  • f9b2507: 8271834: TestStringDeduplicationAgeThreshold intermittent failures on Shenandoah
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/2ee1f96c14b80b63a29445629b1f2e1caf88e075...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 14, 2021
@egahlin
Copy link
Member Author

@egahlin egahlin commented Sep 20, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2021

Going to push as commit 26e5e9a.
Since your change was applied there have been 89 commits pushed to the master branch:

  • 4b3a4ff: 8273940: vmTestbase/vm/mlvm/meth/stress/gc/callSequencesDuringGC/Test.java crashes in full gc during VM exit
  • dad5d27: 8272867: JFR: ManagementSupport.removeBefore() lost coverage
  • 48aff23: 8272515: JFR: Names should only be valid Java identifiers
  • 4d95a5d: 8273933: [TESTBUG] Test must run without preallocated exceptions
  • 9aa12da: 8273934: Remove unused perfcounters
  • 4da45c4: 8270609: [TESTBUG] java/awt/print/Dialog/DialogCopies.java does not show instruction
  • 544193a: 8247980: Exclusive execution of java/util/stream tests slows down tier1
  • 1f8af52: 8273314: Add tier4 test groups
  • 699865f: 8259039: Passing different version to --release flag than javac version output warning
  • f71df14: 8273187: jtools tests fail with missing markerName check
  • ... and 79 more: https://git.openjdk.java.net/jdk/compare/2ee1f96c14b80b63a29445629b1f2e1caf88e075...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2021

@egahlin Pushed as commit 26e5e9a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants