Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273638: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F #5485

Closed
wants to merge 1 commit into from

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Sep 13, 2021

As discussed here #1813 the test should skip the GTK L&F unfortunately the name of the GTK L&F is "GTK look and feel" not "GTK". The ID="GTK" can be used instead.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273638: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5485/head:pull/5485
$ git checkout pull/5485

Update a local copy of the PR:
$ git checkout pull/5485
$ git pull https://git.openjdk.java.net/jdk pull/5485/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5485

View PR using the GUI difftool:
$ git pr show -t 5485

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5485.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 13, 2021

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@mrserb mrserb marked this pull request as ready for review Sep 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 13, 2021

@mrserb The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 13, 2021

Webrevs

Loading

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Sep 13, 2021

The test result shows in linux-x64

----------System.out:(6/323)----------
Testing L&F: javax.swing.plaf.metal.MetalLookAndFeel
Testing L&F: javax.swing.plaf.nimbus.NimbusLookAndFeel
The test is skipped for Nimbus and GTK
Testing L&F: com.sun.java.swing.plaf.motif.MotifLookAndFeel
Unsupported L&F: com.sun.java.swing.plaf.gtk.GTKLookAndFeel
Testing L&F: com.sun.java.swing.plaf.gtk.GTKLookAndFeel
----------System.err:(1/15)----------
STATUS:Passed.

Do you know why it is shown as Unsupported for GTK even in linux?

Loading

@pankaj-bansal
Copy link

@pankaj-bansal pankaj-bansal commented Sep 13, 2021

I just ran this on my Ubuntu 20.04 and I do not see the UnsupportedL&F exception for GTKL&F. The output is as expected.


Testing L&F: javax.swing.plaf.metal.MetalLookAndFeel
Testing L&F: javax.swing.plaf.nimbus.NimbusLookAndFeel
The test is skipped for Nimbus and GTK
Testing L&F: com.sun.java.swing.plaf.motif.MotifLookAndFeel
Testing L&F: com.sun.java.swing.plaf.gtk.GTKLookAndFeel
The test is skipped for Nimbus and GTK


Loading

Copy link

@pankaj-bansal pankaj-bansal left a comment

Look good to me

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 13, 2021

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273638: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F

Reviewed-by: pbansal, psadhukhan, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • b0d0497: 8273584: TypeElement.getSuperclass crashes for a record TypeElement when j.l.Record is not available
  • 4efcd20: 8273478: [macos11] JTabbedPane selected and pressed tab is not legible
  • a73c06d: 8273021: C2: Improve Add and Xor ideal optimizations
  • 9f86082: 8273610: LogTestFixture::restore_config() should not restore options

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 13, 2021
@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Sep 13, 2021

FWIW, the system where it shows the above message is Oracle_Linux_7.9 CI system and it's running headless which this test is
whereas local ubuntu systems are headful.

Loading

@mrserb
Copy link
Member Author

@mrserb mrserb commented Sep 13, 2021

The GTK L&F is unsupported in the headless mode since it depends on the native libraries. So when this test is executed on the headless system it is passed because the GTK L&F is unsupported and that part of the code is skipped. It fails on the headful systems where the GTK is supported and the test tries to verify it. This bug was not reproduced in mach5 because the test is not marked as "@key headful" so it is never run on the headful systems.

Loading

Copy link
Contributor

@prsadhuk prsadhuk left a comment

ok

Loading

@pankaj-bansal
Copy link

@pankaj-bansal pankaj-bansal commented Sep 13, 2021

The test has some wildcard imports. You can remove them if possible, otherwise it is ok.

Loading

@mrserb
Copy link
Member Author

@mrserb mrserb commented Sep 15, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

Going to push as commit 6cf70f5.
Since your change was applied there have been 32 commits pushed to the master branch:

  • e66bf47: 8273414: ResourceObj::operator delete should handle nullptr in debug builds
  • 16c3ad1: 8272574: C2: assert(false) failed: Bad graph detected in build_loop_late
  • e7ab372: 8273641: (bf) Buffer subclasses documentation contains template strings
  • 22a7191: 8273040: Turning off JpAllowDowngrades (or Upgrades)
  • 394ebc8: 8270553: Tests should not use (real, in-use, routable) 1.1.1.1 as dummy IP value
  • 0f31d0f: 8273373: Zero: Cannot invoke JVM in primordial threads on Zero
  • fe89dd3: 8271254: javac generates unreachable code when using empty semicolon statement
  • 8974b95: 8273730: WorkGangBarrierSync constructor unused
  • 1d3eb14: 8273635: Attempting to acquire lock StackWatermark_lock/9 out of order with lock tty_lock/3
  • 31667da: 8273491: java.util.spi.LocaleServiceProvider spec contains statement that is too strict
  • ... and 22 more: https://git.openjdk.java.net/jdk/compare/2ee1f96c14b80b63a29445629b1f2e1caf88e075...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 15, 2021
@openjdk openjdk bot added integrated and removed ready labels Sep 15, 2021
@mrserb mrserb deleted the JDK-8273638 branch Sep 15, 2021
@openjdk openjdk bot removed the rfr label Sep 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

@mrserb Pushed as commit 6cf70f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants