Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254178: Remove .hgignore #549

Closed
wants to merge 3 commits into from

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Oct 7, 2020

After migration to Git, this serves no purpose. The file is not updated, does not seem to be used. We can easily remove it.

There is also .hgtags, but that might have some value for verification, so let's keep it around until Mercurial repos are completely dead for everyone. .hgtags removal is tracked as JDK-8254318.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/549/head:pull/549
$ git checkout pull/549

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 7, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 7, 2020

@shipilev The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Oct 7, 2020
@shipilev shipilev changed the title 8254178: Remove .hgtags and .hgignore 8254178: Remove .hgignore Oct 9, 2020
@shipilev shipilev force-pushed the JDK-8254178-hg-leftovers branch from 66ac64d to 175f0e6 Compare Oct 9, 2020
@shipilev shipilev marked this pull request as ready for review Oct 9, 2020
@openjdk openjdk bot added the rfr label Oct 9, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 9, 2020

Webrevs

edvbld
edvbld approved these changes Oct 17, 2020
Copy link
Member

@edvbld edvbld left a comment

I agree that we can remove the .hgignore file and the removal looks good. Reviewed.

@openjdk
Copy link

openjdk bot commented Oct 17, 2020

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254178: Remove .hgignore

Reviewed-by: ehelin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 134 new commits pushed to the master branch:

  • 0b3e6c5: 8194126: Regression automated Test '/open/test/jdk/javax/swing/JColorChooser/Test7194184.java' fails
  • ce1aac1: 8028707: javax/swing/JComboBox/6236162/bug6236162.java fails on azure
  • 83ea863: 8253559: The INDEX page should link to Serialized Form and Constant Values pages
  • e66c6bb: 8254349: The TestNoScreenMenuBar test should be updated
  • 402d01a: 8254795: Remove obsolete template files
  • 07ec35e: 8254623: gc/g1/TestHumongousConcurrentStartUndo.java still fails sometimes
  • 0570cc1: 8254855: Clean up and remove unused code in vmIntrinsics
  • 1742c44: 8254695: G1: Next mark bitmap clear not cancelled after marking abort
  • 34583eb: 8254161: Prevent instantiation of EnumSet subclasses through deserialization
  • 3d23bd8: 8254814: [Vector API] Fix an AVX512 crash after JDK-8223347
  • ... and 124 more: https://git.openjdk.java.net/jdk/compare/bc236903a29dcf0fc98fa6f68c214c9dacdf30c2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 17, 2020
@shipilev
Copy link
Contributor Author

shipilev commented Oct 19, 2020

/integrate

@openjdk openjdk bot closed this Oct 19, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 19, 2020
@openjdk
Copy link

openjdk bot commented Oct 19, 2020

@shipilev Since your change was applied there have been 138 commits pushed to the master branch:

  • 51a865d: 8254085: javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException: Wrong caret position"
  • dd032b7: 8254798: Deprecate for removal an empty finalize() methods in java.desktop module
  • 272bb5d: 8253455: Record Classes javax.lang.model changes
  • c17d585: 8246774: implement Record Classes as a standard feature in Java
  • 0b3e6c5: 8194126: Regression automated Test '/open/test/jdk/javax/swing/JColorChooser/Test7194184.java' fails
  • ce1aac1: 8028707: javax/swing/JComboBox/6236162/bug6236162.java fails on azure
  • 83ea863: 8253559: The INDEX page should link to Serialized Form and Constant Values pages
  • e66c6bb: 8254349: The TestNoScreenMenuBar test should be updated
  • 402d01a: 8254795: Remove obsolete template files
  • 07ec35e: 8254623: gc/g1/TestHumongousConcurrentStartUndo.java still fails sometimes
  • ... and 128 more: https://git.openjdk.java.net/jdk/compare/bc236903a29dcf0fc98fa6f68c214c9dacdf30c2...master

Your commit was automatically rebased without conflicts.

Pushed as commit 736e077.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8254178-hg-leftovers branch Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build integrated
3 participants