8256735: JFR: 'jfr' tool displays incorrect timestamps

[egahlin]

Hi,

Could I have a review that adds the date to jfr tool output.

Testing: jdk/jdk/jfr + manual inspection

Thanks
Erik

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8256735: JFR: 'jfr' tool displays incorrect timestamps

Reviewers

• Mikhailo Seledtsov (@mseledts - Committer)
• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5494/head:pull/5494
$ git checkout pull/5494

Update a local copy of the PR:
$ git checkout pull/5494
$ git pull https://git.openjdk.java.net/jdk pull/5494/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5494

View PR using the GUI difftool:
$ git pr show -t 5494

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5494.diff

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (66d22eca)

[mseledts]

Looks good to me.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256735: JFR: 'jfr' tool displays incorrect timestamps

Reviewed-by: mseledtsov, mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• f527289: 8273639: tests fail with "assert(_handle_mark_nesting > 1) failed: memory leak: allocating handle outside HandleMark"
• 1d2458d: 8266550: C2: mirror TypeOopPtr/TypeInstPtr/TypeAryPtr with TypeKlassPtr/TypeInstKlassPtr/TypeAryKlassPtr
• a143372: 8273438: Enable parallelism in vmTestbase/metaspace/stressHierarchy tests
• 86a8e55: 8273486: Zero: Handle DiagnoseSyncOnValueBasedClasses VM option
• 8d73ee6: 8273471: Add foldmultilines to UL for stdout/err
• c54a918: 8273691: Missing comma after 2021 in GraphemeTestAccessor.java copyright notice
• 3d9dc8f: 8273430: Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark
• 5095068: 8273675: Remove unused Universe::_verify_in_progress flag
• fc0f854: 8246797: A convenient method to read OPTIONAL element
• 6cf5079: 8273513: Make java.io.FilterInputStream specification more precise about overrides
• ... and 5 more: https://git.openjdk.java.net/jdk/compare/b0d04976bd334f840cb91e3f6dfa2ea680948a39...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit ee3576a.
Since your change was applied there have been 91 commits pushed to the master branch:

• 5fde4b6: 8273909: vmTestbase/nsk/jdi/Event/request/request001 can still fail with "ERROR: new event is not ThreadStartEvent"
• 04891c9: 8273912: Add threadControl_dumpThread(jthread) function
• 5c21c00: 8267163: Rename anonymous loader tests to hidden loader tests
• b3b4b1c: 8273907: Cleanup redundant Math.max/min calls in DefaultHighlighter
• a67f0f9: 8273505: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#default-cl crashed with SIGSEGV in MetaspaceShared::link_shared_classes
• 26e5e9a: 8273654: JFR: Remove unused SecuritySupport.setAccessible(Field)
• 4b3a4ff: 8273940: vmTestbase/vm/mlvm/meth/stress/gc/callSequencesDuringGC/Test.java crashes in full gc during VM exit
• dad5d27: 8272867: JFR: ManagementSupport.removeBefore() lost coverage
• 48aff23: 8272515: JFR: Names should only be valid Java identifiers
• 4d95a5d: 8273933: [TESTBUG] Test must run without preallocated exceptions
• ... and 81 more: https://git.openjdk.java.net/jdk/compare/b0d04976bd334f840cb91e3f6dfa2ea680948a39...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit ee3576a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.