-
Notifications
You must be signed in to change notification settings - Fork 6k
8271254: javac generates unreachable code when using empty semicolon statement #5495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back gli! A progress list of the required criteria for merging this PR into |
Webrevs
|
*/ | ||
void genTry(JCTree body, List<JCCatch> catchers, Env<GenContext> env) { | ||
void genTry(JCTree body, List<JCCatch> catchers, Env<GenContext> env, boolean actualTry) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you really need an additional argument, I think that you can check for the tree at the env
argument and you should be able to find out if this method is being invoked from a try
or not. Kind of:
boolean actualTry = env.tree.hasTag(TRY);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vicente-romero-oracle you are right. I updated the code just now by using the env
instead of the new parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
@lgxbslgx This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 26 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@vicente-romero-oracle Thanks for your review. /integrate |
Going to push as commit fe89dd3.
Your commit was automatically rebased without conflicts. |
Hi all,
The method
Gen#genTry
is used byvisitTry
andvisitSynchronized
, butgenTry
can't identify who is invoking it so that it can't solve the concrete issues about try statement or synchronized statement separately. This patch adds a new parameteractualTry
to identify the concrete situation( try or synchronized) and fixes this issue about using empty skip statement in the try statement body. And some related test cases are added.Thanks for taking the time to review.
Best Regards,
-- Guoxiong
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5495/head:pull/5495
$ git checkout pull/5495
Update a local copy of the PR:
$ git checkout pull/5495
$ git pull https://git.openjdk.java.net/jdk pull/5495/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5495
View PR using the GUI difftool:
$ git pr show -t 5495
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5495.diff