Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273710: Remove redundant stream() call before forEach in jdk.jdeps #5498

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Sep 13, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273710: Remove redundant stream() call before forEach in jdk.jdeps

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5498/head:pull/5498
$ git checkout pull/5498

Update a local copy of the PR:
$ git checkout pull/5498
$ git pull https://git.openjdk.java.net/jdk pull/5498/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5498

View PR using the GUI difftool:
$ git pr show -t 5498

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5498.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 13, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 13, 2021

@turbanoff The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Sep 13, 2021
@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Sep 14, 2021

/issue JDK-8273710

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

@AlanBateman Only the author (@turbanoff) is allowed to issue the /issue command.

@turbanoff turbanoff changed the title [PATCH] Remove redundant stream() call before forEach in jdk.jdeps 8273710: Remove redundant stream() call before forEach in jdk.jdeps Sep 14, 2021
@openjdk openjdk bot added the rfr label Sep 14, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 14, 2021

Webrevs

dfuch
dfuch approved these changes Sep 14, 2021
Copy link
Member

@dfuch dfuch left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273710: Remove redundant stream() call before forEach in jdk.jdeps

Reviewed-by: dfuchs, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

  • 59b2478: 8273659: Replay compilation crashes with SIGSEGV since 8271911
  • 5e4d09c: 8273300: Check Mutex ranking during a safepoint
  • c86e24d: 8271954: C2: assert(false) failed: Bad graph detected in build_loop_late
  • 14dc517: 8273372: Remove scavenge trace message in psPromotionManager
  • 241ac89: 8273606: Zero: SPARC64 build fails with si_band type mismatch
  • 181292d: 8273801: Handle VMTYPE for "core" VM variant
  • 09ecb11: 8273806: compiler/cpuflags/TestSSE4Disabled.java should test for CPU feature explicitly
  • 99cfc16: 8273805: gc/g1/TestGCLogMessages.java test should handle non-JFR configs
  • 1c5de8b: 8273807: Zero: Drop incorrect test block from compiler/startup/NumCompilerThreadsCheck.java
  • 46af82e: 8273804: Platform.isTieredSupported should handle the no-compiler case
  • ... and 37 more: https://git.openjdk.java.net/jdk/compare/fc0f8542c387e7f25992cc7eaa2bb45aeace3c39...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 14, 2021
@turbanoff
Copy link
Member Author

@turbanoff turbanoff commented Sep 15, 2021

/integrate

@openjdk openjdk bot added the sponsor label Sep 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

@turbanoff
Your change (at version d5ff8f1) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Contributor

@shipilev shipilev commented Sep 16, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

Going to push as commit 7e92abe.
Since your change was applied there have been 47 commits pushed to the master branch:

  • 59b2478: 8273659: Replay compilation crashes with SIGSEGV since 8271911
  • 5e4d09c: 8273300: Check Mutex ranking during a safepoint
  • c86e24d: 8271954: C2: assert(false) failed: Bad graph detected in build_loop_late
  • 14dc517: 8273372: Remove scavenge trace message in psPromotionManager
  • 241ac89: 8273606: Zero: SPARC64 build fails with si_band type mismatch
  • 181292d: 8273801: Handle VMTYPE for "core" VM variant
  • 09ecb11: 8273806: compiler/cpuflags/TestSSE4Disabled.java should test for CPU feature explicitly
  • 99cfc16: 8273805: gc/g1/TestGCLogMessages.java test should handle non-JFR configs
  • 1c5de8b: 8273807: Zero: Drop incorrect test block from compiler/startup/NumCompilerThreadsCheck.java
  • 46af82e: 8273804: Platform.isTieredSupported should handle the no-compiler case
  • ... and 37 more: https://git.openjdk.java.net/jdk/compare/fc0f8542c387e7f25992cc7eaa2bb45aeace3c39...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Sep 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

@shipilev @turbanoff Pushed as commit 7e92abe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the jdeps_remove_redundant_stream_before_forEach branch Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
4 participants