Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273635: Attempting to acquire lock StackWatermark_lock/9 out of order with lock tty_lock/3 #5499

Closed
wants to merge 2 commits into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Sep 13, 2021

This change reverts the rank ordering of ttyLock and StackWatermark_lock because the latter is held through a very large region and printing all of this to a buffer with xmlstream is non-trivial.
With this change, if tty->print_cr() is done while holding the stackwatermark lock or lower (which is service ranking, etc), a lock inversion will happen with ttyLock. This doesn't happen now because all the code in GC and much of the rest of the runtime use UL and not tty->print().
Tested with tier1-6.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273635: Attempting to acquire lock StackWatermark_lock/9 out of order with lock tty_lock/3

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5499/head:pull/5499
$ git checkout pull/5499

Update a local copy of the PR:
$ git checkout pull/5499
$ git pull https://git.openjdk.java.net/jdk pull/5499/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5499

View PR using the GUI difftool:
$ git pr show -t 5499

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5499.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 13, 2021

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 13, 2021

@coleenp The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Sep 13, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 13, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Hi Coleen,

The ranking restoration seems fine. One possible typo below.

Thanks,
David

test/hotspot/jtreg/compiler/uncommontrap/TestDeoptOOM.java Outdated Show resolved Hide resolved
@openjdk
Copy link

@openjdk openjdk bot commented Sep 13, 2021

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273635: Attempting to acquire lock StackWatermark_lock/9 out of order with lock tty_lock/3

Reviewed-by: dholmes, eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 31667da: 8273491: java.util.spi.LocaleServiceProvider spec contains statement that is too strict
  • ed7789d: 8256977: Bump minimum GCC from 5.x to 6 for JDK
  • 5bfd043: 8273497: building.md should link to both md and html
  • 3884580: 8273597: Rectify Thread::is_ConcurrentGC_thread()
  • f527289: 8273639: tests fail with "assert(_handle_mark_nesting > 1) failed: memory leak: allocating handle outside HandleMark"
  • 1d2458d: 8266550: C2: mirror TypeOopPtr/TypeInstPtr/TypeAryPtr with TypeKlassPtr/TypeInstKlassPtr/TypeAryKlassPtr
  • a143372: 8273438: Enable parallelism in vmTestbase/metaspace/stressHierarchy tests
  • 86a8e55: 8273486: Zero: Handle DiagnoseSyncOnValueBasedClasses VM option
  • 8d73ee6: 8273471: Add foldmultilines to UL for stdout/err
  • c54a918: 8273691: Missing comma after 2021 in GraphemeTestAccessor.java copyright notice
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/b0d04976bd334f840cb91e3f6dfa2ea680948a39...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 13, 2021
@coleenp
Copy link
Contributor Author

@coleenp coleenp commented Sep 13, 2021

Thanks for the review, David!

fisk
fisk approved these changes Sep 14, 2021
Copy link
Contributor

@fisk fisk left a comment

The rank reversal looks good. Too bad there was more printing code.

@coleenp
Copy link
Contributor Author

@coleenp coleenp commented Sep 14, 2021

Thanks Erik!
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

Going to push as commit 1d3eb14.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 31667da: 8273491: java.util.spi.LocaleServiceProvider spec contains statement that is too strict
  • ed7789d: 8256977: Bump minimum GCC from 5.x to 6 for JDK
  • 5bfd043: 8273497: building.md should link to both md and html
  • 3884580: 8273597: Rectify Thread::is_ConcurrentGC_thread()
  • f527289: 8273639: tests fail with "assert(_handle_mark_nesting > 1) failed: memory leak: allocating handle outside HandleMark"
  • 1d2458d: 8266550: C2: mirror TypeOopPtr/TypeInstPtr/TypeAryPtr with TypeKlassPtr/TypeInstKlassPtr/TypeAryKlassPtr
  • a143372: 8273438: Enable parallelism in vmTestbase/metaspace/stressHierarchy tests
  • 86a8e55: 8273486: Zero: Handle DiagnoseSyncOnValueBasedClasses VM option
  • 8d73ee6: 8273471: Add foldmultilines to UL for stdout/err
  • c54a918: 8273691: Missing comma after 2021 in GraphemeTestAccessor.java copyright notice
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/b0d04976bd334f840cb91e3f6dfa2ea680948a39...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 14, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

@coleenp Pushed as commit 1d3eb14.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the tty branch Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot integrated
3 participants