New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8240751: Shenandoah: fold ShenandoahTracer definition #55
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@shipilev The following labels will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a reviewer, but this looks good to me.
@shipilev This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 22 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
/integrate |
@shipilev Since your change was applied there have been 22 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 382b8fe. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
* JVM-2191: refactor alises in C2 PEA * Add process_phi back. * refactor alias part 2 We remove speciall logic in merge_common. move them to MergeProcess. * Refactor alias part-3 * Refator alias part-4 * Refactor alias part-5 * change _aliases from basic block to compilation unit. * Remove PartialEscapeAnalysis::get_java_oop(). We can't get java_oop from _aliases after we move it from basic block to compilation unit. The same object may get materialized in other basic block and the new CheckCastPP is also a legit alias. We use the straight-forward way to map AllocateNode to CheckCastPP. just check the fixed pattern. alloc->proj#5->checkcastPP. This patch introduces 2 regression in hotspot:tier1 and has rootcaused yet. serviceability/sa/ClhsdbCDSJstackPrintAll.java serviceability/sa/ClhsdbPrintAll.java * Cleanup. * Update per review feedbacks. --------- Co-authored-by: Xin Liu <xxinliu@amazon.com>
Currently, we have
shenandoahTracer.hpp
with a sole definition:This can be folded near the only use at
shenandoahCollectorPolicy.hpp
.Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/55/head:pull/55
$ git checkout pull/55