Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8240751: Shenandoah: fold ShenandoahTracer definition #55

Closed
wants to merge 2 commits into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Sep 7, 2020

Currently, we have shenandoahTracer.hpp with a sole definition:

class ShenandoahTracer : public GCTracer {
public:
  ShenandoahTracer() : GCTracer(Shenandoah) {}
};

This can be folded near the only use at shenandoahCollectorPolicy.hpp.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8240751: Shenandoah: fold ShenandoahTracer definition

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/55/head:pull/55
$ git checkout pull/55

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 7, 2020
@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@shipilev The following labels will be automatically applied to this pull request: hotspot-gc shenandoah.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Sep 7, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 7, 2020

Webrevs

Copy link
Contributor

@adityamandaleeka adityamandaleeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a reviewer, but this looks good to me.

@openjdk
Copy link

openjdk bot commented Sep 9, 2020

@shipilev This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8240751: Shenandoah: fold ShenandoahTracer definition

Reviewed-by: adityam, zgu
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 22 commits pushed to the master branch:

  • c98417e: 8250840: some tests use --enable-preview unnecessarily
  • c655b70: 8252916: Newline in object field values list of ScopeDesc should be removed
  • 30fa8d5: 8157729: examples in LinkedHashMap and LinkedHashSet class doc use raw types
  • 26c7218: 8252773: [TESTBUG] serviceability/jvmti/GetObjectSizeOverflow fails due to OOM conditions
  • e20004d: 8249625: cleanup unused SkippedException in the tests under cds/appcds/dynamicArchive/methodHandles
  • 63a5a12: 8252658: G1: Do not consider G1HeapWastePercent during region selection within a gc
  • 001e51d: 8250563: Add KVHashtable::add_if_absent
  • 91a20ca: 8252695: Shenandoah: clean up Graal enabled/disabled filter in tests
  • 704f784: 8252871: fatal error: must own lock JvmtiThreadState_lock
  • bf5da0c: 8252897: Minor .jcheck/conf update
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/e0c8d4420c8e1a84581927cf77314498b8e5aa52...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate c98417ebca5cf4cb329aedee40267f32a4ae9353.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 9, 2020
@shipilev
Copy link
Member Author

shipilev commented Sep 9, 2020

/integrate

@openjdk openjdk bot closed this Sep 9, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Sep 9, 2020
@openjdk
Copy link

openjdk bot commented Sep 9, 2020

@shipilev Since your change was applied there have been 22 commits pushed to the master branch:

  • c98417e: 8250840: some tests use --enable-preview unnecessarily
  • c655b70: 8252916: Newline in object field values list of ScopeDesc should be removed
  • 30fa8d5: 8157729: examples in LinkedHashMap and LinkedHashSet class doc use raw types
  • 26c7218: 8252773: [TESTBUG] serviceability/jvmti/GetObjectSizeOverflow fails due to OOM conditions
  • e20004d: 8249625: cleanup unused SkippedException in the tests under cds/appcds/dynamicArchive/methodHandles
  • 63a5a12: 8252658: G1: Do not consider G1HeapWastePercent during region selection within a gc
  • 001e51d: 8250563: Add KVHashtable::add_if_absent
  • 91a20ca: 8252695: Shenandoah: clean up Graal enabled/disabled filter in tests
  • 704f784: 8252871: fatal error: must own lock JvmtiThreadState_lock
  • bf5da0c: 8252897: Minor .jcheck/conf update
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/e0c8d4420c8e1a84581927cf77314498b8e5aa52...master

Your commit was automatically rebased without conflicts.

Pushed as commit 382b8fe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 9, 2020
@shipilev shipilev deleted the JDK-8240751 branch September 15, 2020 07:04
caojoshua pushed a commit to caojoshua/jdk that referenced this pull request Jul 26, 2023
* JVM-2191:  refactor alises in C2 PEA

* Add process_phi back.

* refactor alias part 2

We remove speciall logic in merge_common.  move them to MergeProcess.

* Refactor alias part-3

* Refator alias part-4

* Refactor alias part-5

* change _aliases from basic block to compilation unit.

* Remove PartialEscapeAnalysis::get_java_oop().

We can't get java_oop from _aliases after we move it from basic block to
compilation unit. The same object may get materialized in other basic
block and the new CheckCastPP is also a legit alias.

We use the straight-forward way to map AllocateNode to CheckCastPP.
just check the fixed pattern. alloc->proj#5->checkcastPP.

This patch introduces 2 regression in hotspot:tier1 and has rootcaused
yet.
serviceability/sa/ClhsdbCDSJstackPrintAll.java
serviceability/sa/ClhsdbPrintAll.java

* Cleanup.

* Update per review feedbacks.

---------

Co-authored-by: Xin Liu <xxinliu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
3 participants