New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8273711: Remove redundant stream() call before forEach in jdk.jlink #5500
8273711: Remove redundant stream() call before forEach in jdk.jlink #5500
Conversation
|
@turbanoff The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
/issue JDK-8273711 |
@AlanBateman Only the author (@turbanoff) is allowed to issue the |
Webrevs
|
@turbanoff This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 297 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @PaulSandoz, @dfuch) but any other Committer may sponsor as well.
|
In some cases you can use a method ref (no need for another review if you update those).
src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ReleaseInfoPlugin.java
Outdated
Show resolved
Hide resolved
use method references where applicable
/integrate |
@turbanoff |
/sponsor |
Going to push as commit 4e7d7ca.
Your commit was automatically rebased without conflicts. |
@dfuch @turbanoff Pushed as commit 4e7d7ca. |
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5500/head:pull/5500
$ git checkout pull/5500
Update a local copy of the PR:
$ git checkout pull/5500
$ git pull https://git.openjdk.java.net/jdk pull/5500/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5500
View PR using the GUI difftool:
$ git pr show -t 5500
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5500.diff