Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273711: Remove redundant stream() call before forEach in jdk.jlink #5500

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Sep 13, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273711: Remove redundant stream() call before forEach in jdk.jlink

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5500/head:pull/5500
$ git checkout pull/5500

Update a local copy of the PR:
$ git checkout pull/5500
$ git pull https://git.openjdk.java.net/jdk pull/5500/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5500

View PR using the GUI difftool:
$ git pr show -t 5500

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5500.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 13, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 13, 2021

@turbanoff The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Sep 13, 2021
@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Sep 14, 2021

/issue JDK-8273711

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

@AlanBateman Only the author (@turbanoff) is allowed to issue the /issue command.

@turbanoff turbanoff changed the title [PATCH] Remove redundant stream() call before forEach in jdk.jlink 8273711: Remove redundant stream() call before forEach in jdk.jlink Sep 14, 2021
@openjdk openjdk bot added the rfr label Sep 14, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 14, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273711: Remove redundant stream() call before forEach in jdk.jlink

Reviewed-by: alanb, psandoz, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 297 new commits pushed to the master branch:

  • f3cedbe: 8274464: Remove redundant stream() call before forEach in java.* modules
  • c10de35: 8262944: Improve exception message when automatic module lists provider class not in JAR file
  • b8af6a9: 8273917: Remove 'leaf' ranking for Mutex
  • c80a612: 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm
  • 9759fcb: 8274496: Use String.contains() instead of String.indexOf() in java.desktop
  • cdf8930: 8274625: Search field placeholder behavior
  • df125f6: 8273410: IR verification framework fails with "Should find method name in validIrRulesMap"
  • c74726d: 8274730: AArch64: AES/GCM acceleration is broken by the fix for JDK-8273297
  • 2faced0: 8274738: ZGC: Use relaxed atomic load when reading bits in the live map
  • 8a4d2b4: 8274680: Remove unnecessary conversion to String in java.desktop
  • ... and 287 more: https://git.openjdk.java.net/jdk/compare/fc0f8542c387e7f25992cc7eaa2bb45aeace3c39...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @PaulSandoz, @dfuch) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 14, 2021
Copy link
Member

@PaulSandoz PaulSandoz left a comment

In some cases you can use a method ref (no need for another review if you update those).

@turbanoff
Copy link
Member Author

@turbanoff turbanoff commented Sep 17, 2021

/integrate

@openjdk openjdk bot added the sponsor label Sep 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2021

@turbanoff
Your change (at version c071426) is now ready to be sponsored by a Committer.

dfuch
dfuch approved these changes Oct 6, 2021
@dfuch
Copy link
Member

@dfuch dfuch commented Oct 6, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2021

Going to push as commit 4e7d7ca.
Since your change was applied there have been 297 commits pushed to the master branch:

  • f3cedbe: 8274464: Remove redundant stream() call before forEach in java.* modules
  • c10de35: 8262944: Improve exception message when automatic module lists provider class not in JAR file
  • b8af6a9: 8273917: Remove 'leaf' ranking for Mutex
  • c80a612: 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm
  • 9759fcb: 8274496: Use String.contains() instead of String.indexOf() in java.desktop
  • cdf8930: 8274625: Search field placeholder behavior
  • df125f6: 8273410: IR verification framework fails with "Should find method name in validIrRulesMap"
  • c74726d: 8274730: AArch64: AES/GCM acceleration is broken by the fix for JDK-8273297
  • 2faced0: 8274738: ZGC: Use relaxed atomic load when reading bits in the live map
  • 8a4d2b4: 8274680: Remove unnecessary conversion to String in java.desktop
  • ... and 287 more: https://git.openjdk.java.net/jdk/compare/fc0f8542c387e7f25992cc7eaa2bb45aeace3c39...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Oct 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2021

@dfuch @turbanoff Pushed as commit 4e7d7ca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the jlink_remove_redundant_stream_before_forEach branch Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
4 participants