Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction #5503

Closed
wants to merge 4 commits into from

Conversation

lawrence-andrew
Copy link
Contributor

@lawrence-andrew lawrence-andrew commented Sep 13, 2021

Problem :

  1. Test case was failing with following exception
    test result: Error. Parse Exception: Arguments to `manual' option not supported: yes
  2. After removing =yes/no Parser exception is not seen but test UI will show and closes immediately where the user cannot see what is on the frame.

Fix :

  1. Add frame to show the test instructions.
  2. Added timeout for the test case.
  3. Show the test UI until either test case gets timeout or user press pass or fail button.

@shurymury


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273685: Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5503/head:pull/5503
$ git checkout pull/5503

Update a local copy of the PR:
$ git checkout pull/5503
$ git pull https://git.openjdk.java.net/jdk pull/5503/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5503

View PR using the GUI difftool:
$ git pr show -t 5503

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5503.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 13, 2021

👋 Welcome back lawrence-andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 13, 2021
@openjdk
Copy link

openjdk bot commented Sep 13, 2021

@lawrence-andrew The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 13, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 13, 2021

Webrevs

@mrserb
Copy link
Member

mrserb commented Sep 15, 2021

A few suggestions:

  • It will be good to remove horizontal scroll in the instructions.
  • The frames should be closed when the pass/fail buttons are pressed

@shipilev
Copy link
Member

This change looks far beyond "Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTexTAndGraphicsState.java", please change the synopsis to reflect what is going on in the test?

@lawrence-andrew lawrence-andrew changed the title 8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTexTAndGraphicsState.java 8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction Sep 16, 2021
Copy link
Member

@aivanov-jdk aivanov-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest making the component with text rendering smaller?
100 pixel height for each of the tests with text rendered at 20 and 50 instead of 50 and 80;
the entire component will have the height of 300 versus 600.

Does it make sense to a text area with instructions to make it clearer what is expected?
Will attaching a screenshot with garbled text help?

@openjdk
Copy link

openjdk bot commented Sep 17, 2021

@lawrence-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273685: Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction

Reviewed-by: aivanov, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 756 new commits pushed to the master branch:

  • 8302061: 8273774: CDSPluginTest should only expect classes_nocoops.jsa exists on supported 64-bit platforms
  • 2f8c221: 8273681: Add Vector API vs Arrays.mismatch intrinsic benchmark
  • 17f7a45: 8273913: Problem list some headful client jtreg tests that fail on macOS 12
  • 27d747a: 8273877: os::unsetenv unused
  • 35f6f1d: 8273808: Cleanup AddFontsToX11FontPath
  • 1890d85: 8273872: ZGC: Explicitly use 2M large pages
  • 54b4567: 8273880: Zero: Print warnings when unsupported intrinsics are enabled
  • e07ab82: 8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record
  • 8c022e2: 8270434: JDI+UT: Unexpected event in JDI tests
  • b982904: 8271073: Improve testing with VM option VerifyArchivedFields
  • ... and 746 more: https://git.openjdk.java.net/jdk/compare/92ae6a512340485f75a12479dc1c1b8d3261bc76...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk, @pankaj-bansal) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 17, 2021
@lawrence-andrew
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 17, 2021
@openjdk
Copy link

openjdk bot commented Sep 17, 2021

@lawrence-andrew
Your change (at version 1758ddf) is now ready to be sponsored by a Committer.

@aivanov-jdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 17, 2021

Going to push as commit 2a2e919.
Since your change was applied there have been 756 commits pushed to the master branch:

  • 8302061: 8273774: CDSPluginTest should only expect classes_nocoops.jsa exists on supported 64-bit platforms
  • 2f8c221: 8273681: Add Vector API vs Arrays.mismatch intrinsic benchmark
  • 17f7a45: 8273913: Problem list some headful client jtreg tests that fail on macOS 12
  • 27d747a: 8273877: os::unsetenv unused
  • 35f6f1d: 8273808: Cleanup AddFontsToX11FontPath
  • 1890d85: 8273872: ZGC: Explicitly use 2M large pages
  • 54b4567: 8273880: Zero: Print warnings when unsupported intrinsics are enabled
  • e07ab82: 8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record
  • 8c022e2: 8270434: JDI+UT: Unexpected event in JDI tests
  • b982904: 8271073: Improve testing with VM option VerifyArchivedFields
  • ... and 746 more: https://git.openjdk.java.net/jdk/compare/92ae6a512340485f75a12479dc1c1b8d3261bc76...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 17, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 17, 2021
@openjdk
Copy link

openjdk bot commented Sep 17, 2021

@aivanov-jdk @lawrence-andrew Pushed as commit 2a2e919.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
5 participants