Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273691: Missing comma after 2021 in GraphemeTestAccessor.java copyright notice #5504

Closed
wants to merge 1 commit into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Sep 14, 2021

Please review this trivial fix to add the missing comma.

Thanks,
David


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273691: Missing comma after 2021 in GraphemeTestAccessor.java copyright notice

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5504/head:pull/5504
$ git checkout pull/5504

Update a local copy of the PR:
$ git checkout pull/5504
$ git pull https://git.openjdk.java.net/jdk pull/5504/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5504

View PR using the GUI difftool:
$ git pr show -t 5504

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5504.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 14, 2021

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8273691: Missing comma after 2021 in GraphemeTestAccessor.java copyright 8273691: Missing comma after 2021 in GraphemeTestAccessor.java copyright notice Sep 14, 2021
@openjdk openjdk bot added the rfr label Sep 14, 2021
@dholmes-ora
Copy link
Member Author

@dholmes-ora dholmes-ora commented Sep 14, 2021

/label add core-libs

@openjdk openjdk bot added the core-libs label Sep 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

@dholmes-ora
The core-libs label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 14, 2021

Webrevs

@igraves
Copy link
Member

@igraves igraves commented Sep 14, 2021

LGTM. Thanks @dholmes-ora

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273691: Missing comma after 2021 in GraphemeTestAccessor.java copyright notice

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 14, 2021
@dholmes-ora
Copy link
Member Author

@dholmes-ora dholmes-ora commented Sep 14, 2021

Thanks Paul and Ian!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

Going to push as commit c54a918.

@openjdk openjdk bot closed this Sep 14, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

@dholmes-ora Pushed as commit c54a918.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8273691 branch Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
3 participants