8270873: JFR: Catch DirectoryIteratorException when scanning for .jfr files

[egahlin]

Hi,

Could I have a review of a bug fix that adds guards against DirectoryIteratorException while scanning the repository for chunk files.

Testing: test/jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8270873: JFR: Catch DirectoryIteratorException when scanning for .jfr files

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5507/head:pull/5507
$ git checkout pull/5507

Update a local copy of the PR:
$ git checkout pull/5507
$ git pull https://git.openjdk.java.net/jdk pull/5507/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5507

View PR using the GUI difftool:
$ git pr show -t 5507

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5507.diff

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a0f50b66)

[mgronlun]

Looks good.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270873: JFR: Catch DirectoryIteratorException when scanning for .jfr files

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 94 new commits pushed to the master branch:

• afd218d: 8274053: [BACKOUT] JDK-8270842: G1: Only young regions need to redirty outside references in remset.
• a5108a6: 8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher
• 65ed0a7: 8273655: content-types.properties files are missing some common types
• c60bcd0: 8273928: Use named run ids when problem listing tests
• 6642d2e: 8273783: Simplify Metaspace arena guard handling
• f242cb5: 8273797: Stop impersonating "server" VM in all VM variants
• 240fa6e: 8273927: Enable hsdis for riscv64
• 9c91ff5: 8274031: Typo in StringBuilder.readObject
• d16bf04: 8273613: JFR: RemoteRecordingStream::start() blocks close()
• 7ce60c6: 8273651: JFR: onMetadata(), setStartTime(), setEndTime() lacks test coverage
• ... and 84 more: https://git.openjdk.java.net/jdk/compare/3d9dc8f824abf597d9b28f456cfeb5af927221b8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit 57df0db.
Since your change was applied there have been 96 commits pushed to the master branch:

• 111d5e1: 8273915: Create 'nosafepoint' rank
• 7acec3f: 8236505: Mark jdk/editpad/EditPadTest.java as @headful
• afd218d: 8274053: [BACKOUT] JDK-8270842: G1: Only young regions need to redirty outside references in remset.
• a5108a6: 8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher
• 65ed0a7: 8273655: content-types.properties files are missing some common types
• c60bcd0: 8273928: Use named run ids when problem listing tests
• 6642d2e: 8273783: Simplify Metaspace arena guard handling
• f242cb5: 8273797: Stop impersonating "server" VM in all VM variants
• 240fa6e: 8273927: Enable hsdis for riscv64
• 9c91ff5: 8274031: Typo in StringBuilder.readObject
• ... and 86 more: https://git.openjdk.java.net/jdk/compare/3d9dc8f824abf597d9b28f456cfeb5af927221b8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit 57df0db.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.