8258734: jdk/jfr/event/oldobject/TestClassLoaderLeak.java failed with "RuntimeException: Could not find class leak"

[egahlin]

Hi,

Could I have a review of a test fix that prints all old objects events to simplify analysis. I also changed the ratio between loaded classes and instances to increase the likelihood that an object is sampled.

Testing: Running jdk/jfr/event/oldobject/TestClassLoaderLeak.java 100 times

Thanks
Erik

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8258734: jdk/jfr/event/oldobject/TestClassLoaderLeak.java failed with "RuntimeException: Could not find class leak"

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5513/head:pull/5513
$ git checkout pull/5513

Update a local copy of the PR:
$ git checkout pull/5513
$ git pull https://git.openjdk.java.net/jdk pull/5513/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5513

View PR using the GUI difftool:
$ git pr show -t 5513

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5513.diff

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258734: jdk/jfr/event/oldobject/TestClassLoaderLeak.java failed with "RuntimeException: Could not find class leak"

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 103 new commits pushed to the master branch:

• 3f73ca7: 8274068: Rename G1ScanInYoungSetter to G1SkipCardEnqueueSetter
• 7f78803: 8273961: jdk/nio/zipfs/ZipFSTester.java fails if file path contains '+' character
• 51085b5: 8274054: Add custom enqueue calls during reference processing
• c77ebe8: 8274060: C2: Incorrect computation after JDK-8273454
• d9872ba: 8273590: Move helper classes in G1 post evacuation sub tasks to cpp files
• 688b3fe: 8274070: Rectify problemlist platform for failing test on macos12
• eeaf43b: 8274114: ProblemList serviceability/sa/TestJhsdbJstackMixed.java on linux-aarch64 in -Xcomp mode
• 517405e: 8273965: some testlibrary_tests/ir_framework tests fail when c1 disabled
• 11cddd3: 8272114: Unused _last_state in osThread_windows
• cbe57e8: 8273684: Replace usages of java.util.Stack with ArrayDeque
• ... and 93 more: https://git.openjdk.java.net/jdk/compare/ed7789d6a08bcf5e49907389c6c36a09e88e852a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit aefd4ac.
Since your change was applied there have been 104 commits pushed to the master branch:

• d245a8c: 8274069: Clean up g1ParScanThreadState a bit
• 3f73ca7: 8274068: Rename G1ScanInYoungSetter to G1SkipCardEnqueueSetter
• 7f78803: 8273961: jdk/nio/zipfs/ZipFSTester.java fails if file path contains '+' character
• 51085b5: 8274054: Add custom enqueue calls during reference processing
• c77ebe8: 8274060: C2: Incorrect computation after JDK-8273454
• d9872ba: 8273590: Move helper classes in G1 post evacuation sub tasks to cpp files
• 688b3fe: 8274070: Rectify problemlist platform for failing test on macos12
• eeaf43b: 8274114: ProblemList serviceability/sa/TestJhsdbJstackMixed.java on linux-aarch64 in -Xcomp mode
• 517405e: 8273965: some testlibrary_tests/ir_framework tests fail when c1 disabled
• 11cddd3: 8272114: Unused _last_state in osThread_windows
• ... and 94 more: https://git.openjdk.java.net/jdk/compare/ed7789d6a08bcf5e49907389c6c36a09e88e852a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit aefd4ac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mlbridge]

Webrevs

• 00: Full (f0105c9f)