Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271073: Improve testing with VM option VerifyArchivedFields #5514

Closed

Conversation

iklam
Copy link
Member

@iklam iklam commented Sep 14, 2021

  • Changed the definition of VerifyArchivedFields from a whacky use of bool to an int and properly define its three levels:
    • 0: No verification
    • 1: Basic verification with VM_Verify (no side effects)
    • 2: Detailed verification by forcing a GC (with side effects)
  • Changed the default value to 0. The functionality checked by this flag has been very stable so there's no need to verify it in every single test case.
  • Enabled -XX:VerifyArchivedFields=1 for all CDS test cases.
  • Added a new test case for -XX:VerifyArchivedFields=2 .
  • Also added comments about that this flag is suppose to check for.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271073: Improve testing with VM option VerifyArchivedFields

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5514/head:pull/5514
$ git checkout pull/5514

Update a local copy of the PR:
$ git checkout pull/5514
$ git pull https://git.openjdk.java.net/jdk pull/5514/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5514

View PR using the GUI difftool:
$ git pr show -t 5514

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5514.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 14, 2021

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

@iklam The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Sep 14, 2021
@iklam iklam marked this pull request as ready for review Sep 14, 2021
@openjdk openjdk bot added the rfr label Sep 14, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 14, 2021

Webrevs

Copy link
Member

@calvinccheung calvinccheung left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271073: Improve testing with VM option VerifyArchivedFields

Reviewed-by: ccheung, minqi

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

  • bc48a0a: 8273902: Memory leak in OopStorage due to bug in OopHandle::release()
  • 9c5441c: 8271569: Clean up the use of CDS constants and field offsets
  • 12fa707: 8261941: Use ClassLoader for unregistered classes during -Xshare:dump
  • 7e92abe: 8273710: Remove redundant stream() call before forEach in jdk.jdeps
  • 59b2478: 8273659: Replay compilation crashes with SIGSEGV since 8271911
  • 5e4d09c: 8273300: Check Mutex ranking during a safepoint
  • c86e24d: 8271954: C2: assert(false) failed: Bad graph detected in build_loop_late
  • 14dc517: 8273372: Remove scavenge trace message in psPromotionManager
  • 241ac89: 8273606: Zero: SPARC64 build fails with si_band type mismatch
  • 181292d: 8273801: Handle VMTYPE for "core" VM variant
  • ... and 23 more: https://git.openjdk.java.net/jdk/compare/22a7191f700c6966c59dcd12476f01452243542b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 15, 2021
yminqi
yminqi approved these changes Sep 16, 2021
Copy link
Contributor

@yminqi yminqi left a comment

LGTM.

@iklam
Copy link
Member Author

@iklam iklam commented Sep 16, 2021

Thanks @calvinccheung and @yminqi for the review.
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

Going to push as commit b982904.
Since your change was applied there have been 33 commits pushed to the master branch:

  • bc48a0a: 8273902: Memory leak in OopStorage due to bug in OopHandle::release()
  • 9c5441c: 8271569: Clean up the use of CDS constants and field offsets
  • 12fa707: 8261941: Use ClassLoader for unregistered classes during -Xshare:dump
  • 7e92abe: 8273710: Remove redundant stream() call before forEach in jdk.jdeps
  • 59b2478: 8273659: Replay compilation crashes with SIGSEGV since 8271911
  • 5e4d09c: 8273300: Check Mutex ranking during a safepoint
  • c86e24d: 8271954: C2: assert(false) failed: Bad graph detected in build_loop_late
  • 14dc517: 8273372: Remove scavenge trace message in psPromotionManager
  • 241ac89: 8273606: Zero: SPARC64 build fails with si_band type mismatch
  • 181292d: 8273801: Handle VMTYPE for "core" VM variant
  • ... and 23 more: https://git.openjdk.java.net/jdk/compare/22a7191f700c6966c59dcd12476f01452243542b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

@iklam Pushed as commit b982904.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot integrated
4 participants