Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273575: memory leak in appendBootClassPath(), paths must be deallocated #5516

Closed
wants to merge 2 commits into from

Conversation

sspitsyn
Copy link
Contributor

@sspitsyn sspitsyn commented Sep 15, 2021

The memory allocated and hold in the paths local variable of function appendBootClassPath() is never deallocated:
splitPathList(pathList, &count, &paths);
So, it is a memory leak which needs to be fixed.
The fix is to add one line at the end of function:
free(paths);


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273575: memory leak in appendBootClassPath(), paths must be deallocated

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5516/head:pull/5516
$ git checkout pull/5516

Update a local copy of the PR:
$ git checkout pull/5516
$ git pull https://git.openjdk.java.net/jdk pull/5516/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5516

View PR using the GUI difftool:
$ git pr show -t 5516

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5516.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2021

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 15, 2021
@openjdk
Copy link

openjdk bot commented Sep 15, 2021

@sspitsyn The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Sep 15, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 15, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Thanks,
David

@openjdk
Copy link

openjdk bot commented Sep 15, 2021

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273575: memory leak in appendBootClassPath(), paths must be deallocated

Reviewed-by: dholmes, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 15, 2021
@fmatte1
Copy link

fmatte1 commented Sep 15, 2021

Changes looks good to me.

@sspitsyn
Copy link
Contributor Author

David, Fairoz and Alex, thank you for review!

@sspitsyn
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 15, 2021

Going to push as commit 74ffe12.
Since your change was applied there have been 13 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 15, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 15, 2021
@openjdk
Copy link

openjdk bot commented Sep 15, 2021

@sspitsyn Pushed as commit 74ffe12.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sspitsyn sspitsyn deleted the br2 branch September 15, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
4 participants