-
Notifications
You must be signed in to change notification settings - Fork 6k
8273797: Stop impersonating "server" VM in all VM variants #5526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a purely "mechanical" perspective this is a good simplification and cleanup.
Did you test building all variants into one image?
Cheers,
David
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 41 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Yes, I did, but I think the build system is confused about the VM feature sets. I have a vague recollection that ether @magicus or someone else at one point suggested eliminating multi-variant builds, maybe that should be the next step in build simplification. |
@magicus, want to take a look as well? |
Looks good. Thanks for waiting for my input; sorry for the delay. |
As for eliminating multi-JVM builds: yes, that is on my agenda, but as long as I'm still just working part-time it's hard to make any headway in that direction. The next step is to create a
or something like that. When that exists and is working, and all downstream users has had time to adapt, then we can remove multi-JVM build support (and boy am I longing for that day). If you want to help by implementing the |
Thanks! /integrate |
Going to push as commit f242cb5.
Your commit was automatically rebased without conflicts. |
As the follow-up for Zero-specific JDK-8273494, we might want to clean up build system logic for all VM variants: stop impersonating "server" VMs for all of them. This basically leaves "core" and "custom" variants to be handled with this patch.
Additional testing:
core
build passes,libjvm.so
now incore
,jvm.cfg
mentions-core KNOWN
custom
(+serialgc,+compiler2) build passes,libjvm.so
now incustom
,jvm.cfg
mentions-custom KNOWN
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5526/head:pull/5526
$ git checkout pull/5526
Update a local copy of the PR:
$ git checkout pull/5526
$ git pull https://git.openjdk.java.net/jdk pull/5526/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5526
View PR using the GUI difftool:
$ git pr show -t 5526
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5526.diff