Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273803: Zero: Handle "zero" variant in CommandLineOptionTest.java #5527

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Sep 15, 2021

This currently manifests if you run Zero with compiler/codecache/cli tests (part of tier1):

$ CONF=linux-x86_64-zero-fastdebug make exploded-test TEST=compiler/codecache/cli/

STDERR:
java.lang.RuntimeException: Unknown VM mode.
at jdk.test.lib.cli.CommandLineOptionTest.getVMTypeOption(CommandLineOptionTest.java:504)
at jdk.test.lib.cli.CommandLineOptionTest.verifyOptionValueForSameVM(CommandLineOptionTest.java:397)
at compiler.codecache.cli.codeheapsize.GenericCodeHeapSizeRunner.run(GenericCodeHeapSizeRunner.java:42)
at compiler.codecache.cli.common.CodeCacheCLITestCase.run(CodeCacheCLITestCase.java:62)
at compiler.codecache.cli.common.CodeCacheCLITestBase.runTestCases(CodeCacheCLITestBase.java:58)
at compiler.codecache.cli.codeheapsize.TestCodeHeapSizeOptions.main(TestCodeHeapSizeOptions.java:86)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:312)
at java.base/java.lang.Thread.run(Thread.java:833)

While these tests are compiler tests, and they should arguably never run with Zero, the problem is in shared code, which can be used in future by other non-compiler tests.

Additional testing:

  • Affected compiler tests now "properly" fail with "no compilers" errors

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273803: Zero: Handle "zero" variant in CommandLineOptionTest.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5527/head:pull/5527
$ git checkout pull/5527

Update a local copy of the PR:
$ git checkout pull/5527
$ git pull https://git.openjdk.java.net/jdk pull/5527/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5527

View PR using the GUI difftool:
$ git pr show -t 5527

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5527.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 15, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

@shipilev The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Sep 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 15, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Looks fine and trivial.

Cheers,
David

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273803: Zero: Handle "zero" variant in CommandLineOptionTest.java

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 4c673df: 8273656: Improve java.lang.invoke.MethodType.parameterList() and its usage

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 15, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Sep 16, 2021

Thank you!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

Going to push as commit 2d13fb2.
Since your change was applied there have been 9 commits pushed to the master branch:

  • d4546b6: 8273526: Extend the OSContainer API pids controller with pids.current
  • 74ffe12: 8273575: memory leak in appendBootClassPath(), paths must be deallocated
  • cbffecc: 8273832: gc/shenandoah/TestJcmdHeapDump.java does not have a @requires vm.gc.shenandoah
  • 7b2beb6: 8273823: Problemlist gc/stringdedup tests timing out on ZGC
  • 8290424: 8272771: frame::pd_ps() is not implemented on any platform
  • a3ca770: 8272815: jpackage --type rpm produces an error: Invalid or unsupported type: [null]
  • 8132bfd: 8273559: Shenandoah: Shenandoah should support multi-threaded heap dump
  • f531b5c: 8273514: java/util/DoubleStreamSums/CompensatedSums.java failure
  • 4c673df: 8273656: Improve java.lang.invoke.MethodType.parameterList() and its usage

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

@shipilev Pushed as commit 2d13fb2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8273803-zero-commandlineoptiontest branch Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
2 participants