New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8273806: compiler/cpuflags/TestSSE4Disabled.java should test for CPU feature explicitly #5530
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanted to say "Looks good to me but the author of the test should also have a look" but then I noticed that I'm the author. So: Looks good and trivial to me :)
@shipilev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
Yeah ;) Thanks! /integrate |
Going to push as commit 09ecb11.
Your commit was automatically rebased without conflicts. |
JDK-8158214 added a test that verifies that machines with SSE4 support do not crash when lower SSE level is required. But it tests for CPU capabilities weirdly.
This tangentially manifests when running the test with Zero:
I think we can test that target CPU supports SSE4, and only run the test then. It would implicitly fix Zero test failure too, as Zero impersonates a "generic" featureless CPU. Plus, it would stop running the -Xcomp test on arches that do not actually need this test to run.
Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5530/head:pull/5530
$ git checkout pull/5530
Update a local copy of the PR:
$ git checkout pull/5530
$ git pull https://git.openjdk.java.net/jdk pull/5530/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5530
View PR using the GUI difftool:
$ git pr show -t 5530
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5530.diff