Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8273808: Cleanup AddFontsToX11FontPath #5532

Closed
wants to merge 1 commit into from

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Sep 15, 2021

Hello please review this small cleanup change. Seems AddFontsToX11FontPath from fontpath.c is unused/unreferenced and can be removed.

Thanks, Matthias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5532/head:pull/5532
$ git checkout pull/5532

Update a local copy of the PR:
$ git checkout pull/5532
$ git pull https://git.openjdk.java.net/jdk pull/5532/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5532

View PR using the GUI difftool:
$ git pr show -t 5532

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5532.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 15, 2021

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

@MBaesken The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the client label Sep 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 15, 2021

Webrevs

Loading

Copy link

@pankaj-bansal pankaj-bansal left a comment

Looks good to me. I have verified that the function is not referenced anywhere. Just to be sure, I gave a mach5 job also (Link in JBS). Did not see anything wrong.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273808: Cleanup AddFontsToX11FontPath

Reviewed-by: pbansal, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

  • 1890d85: 8273872: ZGC: Explicitly use 2M large pages
  • 54b4567: 8273880: Zero: Print warnings when unsupported intrinsics are enabled
  • e07ab82: 8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record
  • 8c022e2: 8270434: JDI+UT: Unexpected event in JDI tests
  • b982904: 8271073: Improve testing with VM option VerifyArchivedFields
  • bc48a0a: 8273902: Memory leak in OopStorage due to bug in OopHandle::release()
  • 9c5441c: 8271569: Clean up the use of CDS constants and field offsets
  • 12fa707: 8261941: Use ClassLoader for unregistered classes during -Xshare:dump
  • 7e92abe: 8273710: Remove redundant stream() call before forEach in jdk.jdeps
  • 59b2478: 8273659: Replay compilation crashes with SIGSEGV since 8271911
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/4c673df31e46644b21fefa51e0ea01f7d9b94856...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 16, 2021
@MBaesken
Copy link
Member Author

@MBaesken MBaesken commented Sep 16, 2021

Hi Pankaj , thanks for the review and additional testing you did. Can we count this change as trivial or should I wait for a second review ?
Best regards, Matthias

Loading

Copy link
Contributor

@RealLucy RealLucy left a comment

LGTM.

Loading

@MBaesken
Copy link
Member Author

@MBaesken MBaesken commented Sep 17, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2021

Going to push as commit 35f6f1d.
Since your change was applied there have been 28 commits pushed to the master branch:

  • 1890d85: 8273872: ZGC: Explicitly use 2M large pages
  • 54b4567: 8273880: Zero: Print warnings when unsupported intrinsics are enabled
  • e07ab82: 8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record
  • 8c022e2: 8270434: JDI+UT: Unexpected event in JDI tests
  • b982904: 8271073: Improve testing with VM option VerifyArchivedFields
  • bc48a0a: 8273902: Memory leak in OopStorage due to bug in OopHandle::release()
  • 9c5441c: 8271569: Clean up the use of CDS constants and field offsets
  • 12fa707: 8261941: Use ClassLoader for unregistered classes during -Xshare:dump
  • 7e92abe: 8273710: Remove redundant stream() call before forEach in jdk.jdeps
  • 59b2478: 8273659: Replay compilation crashes with SIGSEGV since 8271911
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/4c673df31e46644b21fefa51e0ea01f7d9b94856...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 17, 2021
@openjdk openjdk bot added integrated and removed ready labels Sep 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2021

@MBaesken Pushed as commit 35f6f1d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@openjdk openjdk bot removed the rfr label Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants