8273832: gc/shenandoah/TestJcmdHeapDump.java does not have a @requires vm.gc.shenandoah

[tschatzl]

Hi all,

can I get quick reviews for this change adding necessary @requires labels for builds without Shenandoah?

Currently testing tier2 with this change, but I expect this to work.

Thanks,
Thomas

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8273832: gc/shenandoah/TestJcmdHeapDump.java does not have a @requires vm.gc.shenandoah

Reviewers

• Zhengyu Gu (@zhengyu123 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5535/head:pull/5535
$ git checkout pull/5535

Update a local copy of the PR:
$ git checkout pull/5535
$ git pull https://git.openjdk.java.net/jdk pull/5535/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5535

View PR using the GUI difftool:
$ git pr show -t 5535

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5535.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ea196d59)

[zhengyu123]

Looks good and trivial

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273832: gc/shenandoah/TestJcmdHeapDump.java does not have a @requires vm.gc.shenandoah

Reviewed-by: zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Thanks @zhengyu123 for your reviews.

/integrate

[openjdk]

Going to push as commit cbffecc.

[openjdk]

@tschatzl Pushed as commit cbffecc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.