Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270434: JDI+UT: Unexpected event in JDI tests #5538

Closed
wants to merge 1 commit into from
Closed

8270434: JDI+UT: Unexpected event in JDI tests #5538

wants to merge 1 commit into from

Conversation

alexmenkov
Copy link

@alexmenkov alexmenkov commented Sep 15, 2021

Updated the tests to skip events from unexpected threads.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5538/head:pull/5538
$ git checkout pull/5538

Update a local copy of the PR:
$ git checkout pull/5538
$ git pull https://git.openjdk.java.net/jdk pull/5538/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5538

View PR using the GUI difftool:
$ git pr show -t 5538

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5538.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 15, 2021

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

@alexmenkov The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability label Sep 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 15, 2021

Webrevs

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Hi Alex,
LGTM
Thanks,
Serguei

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270434: JDI+UT: Unexpected event in JDI tests

Reviewed-by: sspitsyn, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • 59b2478: 8273659: Replay compilation crashes with SIGSEGV since 8271911
  • 5e4d09c: 8273300: Check Mutex ranking during a safepoint
  • c86e24d: 8271954: C2: assert(false) failed: Bad graph detected in build_loop_late
  • 14dc517: 8273372: Remove scavenge trace message in psPromotionManager
  • 241ac89: 8273606: Zero: SPARC64 build fails with si_band type mismatch
  • 181292d: 8273801: Handle VMTYPE for "core" VM variant
  • 09ecb11: 8273806: compiler/cpuflags/TestSSE4Disabled.java should test for CPU feature explicitly
  • 99cfc16: 8273805: gc/g1/TestGCLogMessages.java test should handle non-JFR configs
  • 1c5de8b: 8273807: Zero: Drop incorrect test block from compiler/startup/NumCompilerThreadsCheck.java
  • 46af82e: 8273804: Platform.isTieredSupported should handle the no-compiler case
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/e66bf472484f6873faf45d634f17b68777fdcfa6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 16, 2021
@kevinjwalls
Copy link

@kevinjwalls kevinjwalls commented Sep 16, 2021

Looks good to me too.

I struggled to verify the name "thread2" was correct for testThreadName, I think I found it in vmTestbase/nsk/jdi/EventIterator/nextEvent/nextevent001a.java: thread2 = new Thread3nextevent001a("thread2");

@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Sep 16, 2021

Looks good to me too.

I struggled to verify the name "thread2" was correct for testThreadName, I think I found it in vmTestbase/nsk/jdi/EventIterator/nextEvent/nextevent001a.java: thread2 = new Thread3nextevent001a("thread2");

Yes, that's right

@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Sep 16, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

Going to push as commit 8c022e2.
Since your change was applied there have been 31 commits pushed to the master branch:

  • b982904: 8271073: Improve testing with VM option VerifyArchivedFields
  • bc48a0a: 8273902: Memory leak in OopStorage due to bug in OopHandle::release()
  • 9c5441c: 8271569: Clean up the use of CDS constants and field offsets
  • 12fa707: 8261941: Use ClassLoader for unregistered classes during -Xshare:dump
  • 7e92abe: 8273710: Remove redundant stream() call before forEach in jdk.jdeps
  • 59b2478: 8273659: Replay compilation crashes with SIGSEGV since 8271911
  • 5e4d09c: 8273300: Check Mutex ranking during a safepoint
  • c86e24d: 8271954: C2: assert(false) failed: Bad graph detected in build_loop_late
  • 14dc517: 8273372: Remove scavenge trace message in psPromotionManager
  • 241ac89: 8273606: Zero: SPARC64 build fails with si_band type mismatch
  • ... and 21 more: https://git.openjdk.java.net/jdk/compare/e66bf472484f6873faf45d634f17b68777fdcfa6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

@alexmenkov Pushed as commit 8c022e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alexmenkov alexmenkov deleted the nsk_jdi_ut1 branch Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated serviceability
3 participants