8252133: The java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java fails if metal pipeline is active #554

mrserb · 2020-10-08T04:22:10Z

This bug easily reproduced by the test in question on the dual video card systems
when the metal pipeline is active. But it is possible to reproduce it in the OGL
pipeline as well, but it is required some additional steps.

Problem description:
Our CGraphicsEnvironment maintains the list of active graphics devices. The one
important feature of this CGraphicsEnvironment is to invalidate the old devices and
map them to the new devices. For example, if the user got a reference to the device,
and this device was removed then this reference will refer to the main screen.

The problem in the current implementation arise when the system has two video cards:
1 The user get some GraphicsDevice
2 The user sets the full-screen window for this device
3 The user change screen resolution for this device
4 The resolution of the screen is not changed ->> BUG.

The problem is that somewhere after step 1 or 2 and before step 3 the macOS decided
to switch to the discrete video card, but it does not report the old device(integrated VC)
as removed, because actually no screens were removed.

Since it was not reported as removed we did not invalidate it and did not map it to the
new device ->> request to change the screen resolution at step 3 send to some non existed
deviceID.

As a fix I suggest to change this current logic:

Invalidate devices reported by macOS as removed
Initialize the main screen
Initialize all NEW screens

To this logic:

Ignore devices reported by the macOS as removed
Initialize the main screen
Initialize all NEW screens
Check that the main device is in the list of all NEW devices
Invalidate all OLD devices which are not in the list of NEW devices

The old review request:
https://mail.openjdk.java.net/pipermail/2d-dev/2020-August/011011.html

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Testing

	Linux x64	Windows x64	macOS x64
Build	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

JDK-8252133: The java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java fails if metal pipeline is active

Reviewers

Phil Race (@prrace - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/554/head:pull/554
$ git checkout pull/554

…ails if metal pipeline is active

mrserb · 2020-10-08T04:47:56Z

/cc lanai

bridgekeeper · 2020-10-08T06:50:17Z

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2020-10-08T06:55:48Z

@mrserb The label lanai is not a valid label. These labels are valid:

serviceability
hotspot
sound
hotspot-compiler
kulla
i18n
shenandoah
jdk
javadoc
2d
security
swing
hotspot-runtime
jmx
build
nio
beans
core-libs
compiler
net
hotspot-gc
hotspot-jfr
awt

openjdk · 2020-10-08T06:56:26Z

@mrserb The following label will be automatically applied to this pull request:

awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mrserb · 2020-10-08T06:56:55Z

/cc 2d

mrserb · 2020-10-08T06:57:16Z

/label remove awt

openjdk · 2020-10-08T07:02:13Z

@mrserb
The 2d label was successfully added.

openjdk · 2020-10-08T07:05:32Z

@mrserb
The awt label was successfully removed.

mlbridge · 2020-10-08T07:14:52Z

Webrevs

Make sure the main display is in the list of all displays. Prevent duplicate main screen if the switch has happened.

openjdk · 2020-10-19T23:45:56Z

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252133: The java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java fails if metal pipeline is active

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 164 new commits pushed to the master branch:

294e070: 8254998: C2: assert(!n->as_Loop()->is_transformed_long_loop()) failure with -XX:StressLongCountedLoop=1
3ee0380: 8234393: [macos] printing ignores printer tray
3f9c8a3: 8254966: Remove unused code from Matcher
21e67e5: 8225790: Two NestedDialogs tests fail on Ubuntu
017d151: 8254842: [JVMCI] copy thread name when attaching libgraal thread to HotSpot
5d1397f: 8254282: Add Linux x86_32 builds to submit workflow
7ba6a6b: 8251158: Implementation of JEP 387: Elastic Metaspace
5fedfa7: 8251271: C2: Compile::_for_igvn list is corrupted after RenumberLiveNodes
98ec4a6: 8254805: compiler/debug/TestStressCM.java is still failing
355f44d: 8254994: [x86] C1 StubAssembler::call_RT, "call_offset might not be initialized"
... and 154 more: https://git.openjdk.java.net/jdk/compare/ced46b19f70382d50a45fb54a58bcb9f742fb008...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

azuev-java · 2020-10-20T23:43:46Z

src/java.desktop/macosx/classes/sun/awt/CGraphicsEnvironment.java

+                                                : new CGraphicsDevice(id));
+        }
+        // fetch the main display again, the old value might be outdated
+        mainDisplayID = getMainDisplayID();


What action since line 162 can trigger changing the getMainDisplayID() outcome?

If the main screen is not in the list of screens means that the system monitors were changed in some way after this method was called and we will get one more notification later.

mrserb · 2020-10-21T00:14:59Z

/integrate

openjdk · 2020-10-21T00:19:40Z

@mrserb Since your change was applied there have been 199 commits pushed to the master branch:

afc967f: 8254783: jpackage fails on Windows when application name differs from installer name
3ccf487: 8253019: Enhanced JPEG decoding
cfb02d4: 8250861: Crash in MinINode::Ideal(PhaseGVN*, bool)
0d35235: 8249927: Specify limits of jdk.serialProxyInterfaceLimit
d6cef99: 8245417: Improve certificate chain handling
24f7f84: 8245412: Better class definitions
00a5af4: 8248574: Improve jpeg processing
036da99: 8236862: Enhance support of Proxy class
29c6808: 8243302: Advanced class supports
7eda119: 8237990: Enhanced LDAP contexts
... and 189 more: https://git.openjdk.java.net/jdk/compare/ced46b19f70382d50a45fb54a58bcb9f742fb008...master

Your commit was automatically rebased without conflicts.

Pushed as commit e5870cf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

mrserb and others added 4 commits September 10, 2020 16:24

8252133: The java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java f…

f632ced

…ails if metal pipeline is active

Merge branch 'master' into JDK-8252133

01bdc7e

Update CycleDMImage.java

74ffad2

Merge branch 'master' into JDK-8252133

5dc06c0

openjdk bot added the awt client-libs-dev@openjdk.org label Oct 8, 2020

openjdk bot added the 2d client-libs-dev@openjdk.org label Oct 8, 2020

openjdk bot removed the awt client-libs-dev@openjdk.org label Oct 8, 2020

mrserb marked this pull request as ready for review October 8, 2020 07:10

openjdk bot added the rfr Pull request is ready for review label Oct 8, 2020

mrserb marked this pull request as draft October 8, 2020 23:42

openjdk bot removed the rfr Pull request is ready for review label Oct 8, 2020

Sergey Bylokhov and others added 3 commits October 8, 2020 18:56

Update CGraphicsEnvironment.java

93ebb04

Make sure the main display is in the list of all displays. Prevent duplicate main screen if the switch has happened.

Merge branch 'master' into JDK-8252133

a38ef0e

Update CGraphicsEnvironment.java

0b81a0f

mrserb marked this pull request as ready for review October 11, 2020 07:50

openjdk bot added the rfr Pull request is ready for review label Oct 11, 2020

prrace approved these changes Oct 19, 2020

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 19, 2020

azuev-java reviewed Oct 20, 2020

View reviewed changes

openjdk bot closed this Oct 21, 2020

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 21, 2020

mrserb deleted the JDK-8252133 branch April 12, 2021 21:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8252133: The java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java fails if metal pipeline is active #554

8252133: The java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java fails if metal pipeline is active #554

Uh oh!

mrserb commented Oct 8, 2020 •

edited by openjdk bot

Loading

Uh oh!

mrserb commented Oct 8, 2020

Uh oh!

bridgekeeper bot commented Oct 8, 2020

Uh oh!

openjdk bot commented Oct 8, 2020

Uh oh!

openjdk bot commented Oct 8, 2020

Uh oh!

mrserb commented Oct 8, 2020

Uh oh!

mrserb commented Oct 8, 2020

Uh oh!

openjdk bot commented Oct 8, 2020

Uh oh!

openjdk bot commented Oct 8, 2020

Uh oh!

mlbridge bot commented Oct 8, 2020 •

edited

Loading

Uh oh!

openjdk bot commented Oct 19, 2020 •

edited

Loading

Uh oh!

azuev-java Oct 20, 2020

Uh oh!

mrserb Oct 21, 2020

Uh oh!

mrserb commented Oct 21, 2020

Uh oh!

openjdk bot commented Oct 21, 2020

Uh oh!

Uh oh!

8252133: The java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java fails if metal pipeline is active #554

8252133: The java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java fails if metal pipeline is active #554

Uh oh!

Conversation

mrserb commented Oct 8, 2020 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Testing

Issue

Reviewers

Download

Uh oh!

mrserb commented Oct 8, 2020

Uh oh!

bridgekeeper bot commented Oct 8, 2020

Uh oh!

openjdk bot commented Oct 8, 2020

Uh oh!

openjdk bot commented Oct 8, 2020

Uh oh!

mrserb commented Oct 8, 2020

Uh oh!

mrserb commented Oct 8, 2020

Uh oh!

openjdk bot commented Oct 8, 2020

Uh oh!

openjdk bot commented Oct 8, 2020

Uh oh!

mlbridge bot commented Oct 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

openjdk bot commented Oct 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azuev-java Oct 20, 2020

Choose a reason for hiding this comment

Uh oh!

mrserb Oct 21, 2020

Choose a reason for hiding this comment

Uh oh!

mrserb commented Oct 21, 2020

Uh oh!

openjdk bot commented Oct 21, 2020

Uh oh!

Uh oh!

mrserb commented Oct 8, 2020 •

edited by openjdk bot

Loading

mlbridge bot commented Oct 8, 2020 •

edited

Loading

openjdk bot commented Oct 19, 2020 •

edited

Loading