Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8236505: Mark jdk/editpad/EditPadTest.java as @headful #5544

Closed

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Sep 16, 2021

This is a GUI test, and it should be @headful.

Additional testing:

  • Test still runs in default, and does not run with !headful

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5544/head:pull/5544
$ git checkout pull/5544

Update a local copy of the PR:
$ git checkout pull/5544
$ git pull https://git.openjdk.java.net/jdk pull/5544/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5544

View PR using the GUI difftool:
$ git pr show -t 5544

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5544.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 16, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

@shipilev To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

Copy link
Contributor

@lahodaj lahodaj left a comment

Marking the test headful if OK - but should headful also be added to the keys in test/langtools/TEST.ROOT? (I am not quite sure how that works.)

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Sep 16, 2021

/label core-libs

@openjdk openjdk bot added the core-libs label Sep 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

@shipilev
The core-libs label was successfully added.

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Sep 16, 2021

Marking the test headful if OK - but should headful also be added to the keys in test/langtools/TEST.ROOT? (I am not quite sure how that works.)

AFAICS, this test is in jdk, so it is covered by jdk/TEST.ROOT. I tested it with and without JTREG_KEYWORDS=\!headful, and it behaves as expected.

@lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Sep 16, 2021

Ah, right, I thought it is a JShell test, but it is not. Sorry for the noise.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 16, 2021

Webrevs

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Sep 17, 2021

@lahodaj, would you like to formally ack this PR?

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Sep 21, 2021

Any takers? ;)

@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8236505: Mark jdk/editpad/EditPadTest.java as @headful

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 69 new commits pushed to the master branch:

  • afd218d: 8274053: [BACKOUT] JDK-8270842: G1: Only young regions need to redirty outside references in remset.
  • a5108a6: 8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher
  • 65ed0a7: 8273655: content-types.properties files are missing some common types
  • c60bcd0: 8273928: Use named run ids when problem listing tests
  • 6642d2e: 8273783: Simplify Metaspace arena guard handling
  • f242cb5: 8273797: Stop impersonating "server" VM in all VM variants
  • 240fa6e: 8273927: Enable hsdis for riscv64
  • 9c91ff5: 8274031: Typo in StringBuilder.readObject
  • d16bf04: 8273613: JFR: RemoteRecordingStream::start() blocks close()
  • 7ce60c6: 8273651: JFR: onMetadata(), setStartTime(), setEndTime() lacks test coverage
  • ... and 59 more: https://git.openjdk.java.net/jdk/compare/8fbcc8239a3fc04e56ebbd287c7bb5db731977b7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 21, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Sep 21, 2021

Thank you!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2021

Going to push as commit 7acec3f.
Since your change was applied there have been 69 commits pushed to the master branch:

  • afd218d: 8274053: [BACKOUT] JDK-8270842: G1: Only young regions need to redirty outside references in remset.
  • a5108a6: 8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher
  • 65ed0a7: 8273655: content-types.properties files are missing some common types
  • c60bcd0: 8273928: Use named run ids when problem listing tests
  • 6642d2e: 8273783: Simplify Metaspace arena guard handling
  • f242cb5: 8273797: Stop impersonating "server" VM in all VM variants
  • 240fa6e: 8273927: Enable hsdis for riscv64
  • 9c91ff5: 8274031: Typo in StringBuilder.readObject
  • d16bf04: 8273613: JFR: RemoteRecordingStream::start() blocks close()
  • 7ce60c6: 8273651: JFR: onMetadata(), setStartTime(), setEndTime() lacks test coverage
  • ... and 59 more: https://git.openjdk.java.net/jdk/compare/8fbcc8239a3fc04e56ebbd287c7bb5db731977b7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2021

@shipilev Pushed as commit 7acec3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prrace
Copy link
Contributor

@prrace prrace commented Sep 22, 2021

Well .. since our test framework doesn't run whatever test group this is in on headful systems, what this change has effectively done is say "don't run this test anymore. ever".
You'd need to add it to the desktop test group.

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Sep 23, 2021

You'd need to add it to the desktop test group.

Right. See #5648.

@shipilev shipilev deleted the JDK-8236505-editpad-headful branch Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
3 participants