Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274757: Cleanup unnecessary calls to Throwable.initCause() in java.management module #5552

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Sep 16, 2021

Pass cause exception as constructor parameter is shorter and easier to read.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274757: Cleanup unnecessary calls to Throwable.initCause() in java.management module

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5552/head:pull/5552
$ git checkout pull/5552

Update a local copy of the PR:
$ git checkout pull/5552
$ git pull https://git.openjdk.java.net/jdk pull/5552/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5552

View PR using the GUI difftool:
$ git pr show -t 5552

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5552.diff

turbanoff added 2 commits Sep 16, 2021
…nagement

Pass cause exception as constructor parameter is shorter and easier to read.
…nagement

Pass cause exception as constructor parameter is shorter and easier to read.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 16, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

@turbanoff The following labels will be automatically applied to this pull request:

  • jmx
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability jmx labels Sep 16, 2021
@turbanoff turbanoff changed the title [PATCH] Cleanup unnecessary calls to Throwable.initCause() in java.management 8274757: Cleanup unnecessary calls to Throwable.initCause() in java.management module Oct 5, 2021
@openjdk openjdk bot added the rfr label Oct 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 5, 2021

Webrevs

dfuch
dfuch approved these changes Oct 5, 2021
Copy link
Member

@dfuch dfuch left a comment

Nice simplification.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274757: Cleanup unnecessary calls to Throwable.initCause() in java.management module

Reviewed-by: dfuchs, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 237 new commits pushed to the master branch:

  • 8a4d2b4: 8274680: Remove unnecessary conversion to String in java.desktop
  • 986ee5d: 8274670: Improve version string handling in SA
  • df7b0c7: 8274715: Implement forEach in Collections.CopiesList
  • d4e8712: 8274797: ProblemList resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java on macosx-x64
  • 4726267: 8274642: jdk/jshell/CommandCompletionTest.java fails with NoSuchElementException after JDK-8271287
  • 83b2219: 8273612: Fix for JDK-8272873 causes timeout in running some tests with -Xcomp
  • d34ec6c: 8274793: Suppress warnings on non-serializable non-transient instance fields in sun.net
  • 332f067: 8274729: Define Position.NOPOS == Diagnostic.NOPOS
  • 1e75203: 8274656: Remove default_checksum and safe_checksum_type from krb5.conf
  • 03d3c03: 8273670: Remove weak etypes from default krb5 etype list
  • ... and 227 more: https://git.openjdk.java.net/jdk/compare/bc48a0ac297b99a997482dcb59f85acc1cdb0c47...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch, @sspitsyn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Oct 5, 2021
Copy link
Contributor

@sspitsyn sspitsyn left a comment

I agree with Daniel, it is nice simplification.
Looks good.
Thanks,
Serguei

@turbanoff
Copy link
Member Author

@turbanoff turbanoff commented Oct 6, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2021

@turbanoff
Your change (at version 1d46694) is now ready to be sponsored by a Committer.

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 3, 2021

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sspitsyn
Copy link
Contributor

@sspitsyn sspitsyn commented Nov 16, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 16, 2021

Going to push as commit 1c45c8a.
Since your change was applied there have been 761 commits pushed to the master branch:

  • c06df25: 8274662: Replace 'while' cycles with iterator with enhanced-for in jdk.hotspot.agent
  • 9629627: 8274163: Use String.equals instead of String.compareTo in jdk.jcmd
  • 0bc2683: 8274190: Use String.equals instead of String.compareTo in jdk.internal.jvmstat
  • a9cb8bd: 8274168: Avoid String.compareTo == 0 to check String equality in java.management
  • 20f3872: 8274261: Use enhanced-for instead of plain 'for' in jdk.jcmd
  • b8d33a2: 8277029: JMM GetDiagnosticXXXInfo APIs should verify output array sizes
  • 1d79cfd: 8276229: Stop allowing implicit updates in G1BlockOffsetTable
  • 7719a74: 8277172: Remove stray comment mentioning instr_size_for_decode_klass_not_null on x64
  • e436200: 8008243: Zero: Implement fast bytecodes
  • bd92674: 8276184: Exclude lambda proxy class from the CDS archive if its caller class is excluded
  • ... and 751 more: https://git.openjdk.java.net/jdk/compare/bc48a0ac297b99a997482dcb59f85acc1cdb0c47...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 16, 2021

@sspitsyn @turbanoff Pushed as commit 1c45c8a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the unnecessary_call_to_Throwable.initCause_in_java.management branch Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated jmx serviceability
3 participants