New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8273913: Problem list some headful client jtreg tests that fail on macOS 12 #5553
Conversation
|
/label client |
@prrace To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
@prrace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. BTW there is a warning for title mismatch between JBS and PR.
@prrace This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
That is because (grumble) when a summary is longer than githib likes it splits the summary ending it with ... and puts the rest in the description. Which I expect would ALSO cause a mismatch. So I have to manually join it up again and I left an extra space. Does anyone know why that splitting happens ? |
/integrate |
Going to push as commit 17f7a45.
Your commit was automatically rebased without conflicts. |
Simple Problem list update
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5553/head:pull/5553
$ git checkout pull/5553
Update a local copy of the PR:
$ git checkout pull/5553
$ git pull https://git.openjdk.java.net/jdk pull/5553/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5553
View PR using the GUI difftool:
$ git pr show -t 5553
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5553.diff