Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273913: Problem list some headful client jtreg tests that fail on macOS 12 #5553

Closed
wants to merge 1 commit into from
Closed

Conversation

@prrace
Copy link
Contributor

@prrace prrace commented Sep 16, 2021

Simple Problem list update


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273913: Problem list some headful client jtreg tests that fail on macOS 12

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5553/head:pull/5553
$ git checkout pull/5553

Update a local copy of the PR:
$ git checkout pull/5553
$ git pull https://git.openjdk.java.net/jdk pull/5553/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5553

View PR using the GUI difftool:
$ git pr show -t 5553

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5553.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 16, 2021

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 16, 2021
@prrace
Copy link
Contributor Author

@prrace prrace commented Sep 16, 2021

/label client

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

@prrace To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

Loading

@openjdk openjdk bot added the client label Sep 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

@prrace
The client label was successfully added.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 16, 2021

Webrevs

Loading

Copy link

@pankaj-bansal pankaj-bansal left a comment

Looks good to me. BTW there is a warning for title mismatch between JBS and PR.

Loading

@prrace prrace changed the title 8273913: Problem list some headful client jtreg tests that fail on macOS12 8273913: Problem list some headful client jtreg tests that fail on macOS 12 Sep 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2021

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273913: Problem list some headful client jtreg tests that fail on macOS 12

Reviewed-by: pbansal, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 27d747a: 8273877: os::unsetenv unused
  • 35f6f1d: 8273808: Cleanup AddFontsToX11FontPath
  • 1890d85: 8273872: ZGC: Explicitly use 2M large pages
  • 54b4567: 8273880: Zero: Print warnings when unsupported intrinsics are enabled
  • e07ab82: 8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record
  • 8c022e2: 8270434: JDI+UT: Unexpected event in JDI tests
  • b982904: 8271073: Improve testing with VM option VerifyArchivedFields

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 17, 2021
@prrace
Copy link
Contributor Author

@prrace prrace commented Sep 17, 2021

Looks good to me. BTW there is a warning for title mismatch between JBS and PR.

That is because (grumble) when a summary is longer than githib likes it splits the summary ending it with ... and puts the rest in the description. Which I expect would ALSO cause a mismatch. So I have to manually join it up again and I left an extra space.

Does anyone know why that splitting happens ?

Loading

@prrace
Copy link
Contributor Author

@prrace prrace commented Sep 17, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2021

Going to push as commit 17f7a45.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 27d747a: 8273877: os::unsetenv unused
  • 35f6f1d: 8273808: Cleanup AddFontsToX11FontPath
  • 1890d85: 8273872: ZGC: Explicitly use 2M large pages
  • 54b4567: 8273880: Zero: Print warnings when unsupported intrinsics are enabled
  • e07ab82: 8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record
  • 8c022e2: 8270434: JDI+UT: Unexpected event in JDI tests
  • b982904: 8271073: Improve testing with VM option VerifyArchivedFields

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2021

@prrace Pushed as commit 17f7a45.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants