Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12 #5564

Closed
wants to merge 3 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Sep 17, 2021

The test sometimes fail on macos12 citing "Action has not been received". Seems like some key events sometimes are not received reliably.
Proposed fix is to apply mach5 stability fixes which is to set autodelay to 100ms, move frame to center of screen from top-left, added extra waitForIdle(), wait for 1 sec after frame is made visible.
Additionally, it is seen that it mixes Util.hitKeys and robot.keyPress/Release. Changed to make it use robot.keyPress/keyRelease all times. Also, updated test to have specific error message for specific keyevent so that we know which keyevent is not received in case it fails again.

Run on mac12 and all other platforms multiple times and test run is green. Link in JBS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5564/head:pull/5564
$ git checkout pull/5564

Update a local copy of the PR:
$ git checkout pull/5564
$ git pull https://git.openjdk.java.net/jdk pull/5564/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5564

View PR using the GUI difftool:
$ git pr show -t 5564

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5564.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 17, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 17, 2021
@openjdk
Copy link

openjdk bot commented Sep 17, 2021

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 17, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 17, 2021

Webrevs

@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 23, 2021
Copy link
Member

@mrserb mrserb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see what additional information by this logging we can get next time.

@mrserb
Copy link
Member

mrserb commented Sep 23, 2021

Do you need to remove it from the problem list?

@jayathirthrao
Copy link
Member

8273578 is used in problem lists: [test/jdk/ProblemList.txt] dont know why this error is shown. I dont see it in problemList.
@prsadhuk please verify before push.

@openjdk
Copy link

openjdk bot commented Sep 23, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12

Reviewed-by: jdv, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 23, 2021
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 23, 2021

Going to push as commit 45adc92.

@openjdk openjdk bot closed this Sep 23, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 23, 2021
@openjdk
Copy link

openjdk bot commented Sep 23, 2021

@prsadhuk Pushed as commit 45adc92.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8273578 branch September 23, 2021 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants