Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273505: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#default-cl crashed with SIGSEGV in MetaspaceShared::link_shared_classes #5566

Conversation

calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented Sep 17, 2021

Please review this small patch for keeping the class loader, which is the holder of the ClassLoaderData, alive during class linking within MetaspaceShared::link_shared_classes(). Prior to this fix, the ClassLoaderData::inc_keep_alive() was used in an attempt to keep the ClassLoaderData alive but that was for hidden classes only.

Testing: tiers 1 - 4.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273505: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#default-cl crashed with SIGSEGV in MetaspaceShared::link_shared_classes

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5566/head:pull/5566
$ git checkout pull/5566

Update a local copy of the PR:
$ git checkout pull/5566
$ git pull https://git.openjdk.java.net/jdk pull/5566/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5566

View PR using the GUI difftool:
$ git pr show -t 5566

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5566.diff

…sTest.java#default-cl crashed with SIGSEGV in MetaspaceShared::link_shared_classes
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 17, 2021

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@calvinccheung
Copy link
Member Author

calvinccheung commented Sep 17, 2021

/label remove hotspot
/label add hotspot-runtime

@openjdk
Copy link

openjdk bot commented Sep 17, 2021

@calvinccheung The hotspot label was not set.

@openjdk openjdk bot added the hotspot-runtime label Sep 17, 2021
@openjdk
Copy link

openjdk bot commented Sep 17, 2021

@calvinccheung
The hotspot-runtime label was successfully added.

@calvinccheung calvinccheung marked this pull request as ready for review Sep 17, 2021
@openjdk openjdk bot added the rfr label Sep 17, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 17, 2021

Webrevs

iklam
iklam approved these changes Sep 17, 2021
Copy link
Member

@iklam iklam left a comment

LGTM

@openjdk
Copy link

openjdk bot commented Sep 17, 2021

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273505: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#default-cl crashed with SIGSEGV in MetaspaceShared::link_shared_classes

Reviewed-by: iklam, minqi

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 2a2e919: 8273685: Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction
  • 8302061: 8273774: CDSPluginTest should only expect classes_nocoops.jsa exists on supported 64-bit platforms
  • 2f8c221: 8273681: Add Vector API vs Arrays.mismatch intrinsic benchmark
  • 17f7a45: 8273913: Problem list some headful client jtreg tests that fail on macOS 12
  • 27d747a: 8273877: os::unsetenv unused
  • 35f6f1d: 8273808: Cleanup AddFontsToX11FontPath
  • 1890d85: 8273872: ZGC: Explicitly use 2M large pages
  • 54b4567: 8273880: Zero: Print warnings when unsupported intrinsics are enabled
  • e07ab82: 8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record
  • 8c022e2: 8270434: JDI+UT: Unexpected event in JDI tests
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/9c5441c9c4eea2ea4ba78ee426729bf646dc042d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 17, 2021
yminqi
yminqi approved these changes Sep 17, 2021
Copy link
Contributor

@yminqi yminqi left a comment

LGTM.

@calvinccheung
Copy link
Member Author

calvinccheung commented Sep 20, 2021

Thanks @iklam, @yminqi for the review.
/integrate

@openjdk
Copy link

openjdk bot commented Sep 20, 2021

Going to push as commit a67f0f9.
Since your change was applied there have been 29 commits pushed to the master branch:

  • 26e5e9a: 8273654: JFR: Remove unused SecuritySupport.setAccessible(Field)
  • 4b3a4ff: 8273940: vmTestbase/vm/mlvm/meth/stress/gc/callSequencesDuringGC/Test.java crashes in full gc during VM exit
  • dad5d27: 8272867: JFR: ManagementSupport.removeBefore() lost coverage
  • 48aff23: 8272515: JFR: Names should only be valid Java identifiers
  • 4d95a5d: 8273933: [TESTBUG] Test must run without preallocated exceptions
  • 9aa12da: 8273934: Remove unused perfcounters
  • 4da45c4: 8270609: [TESTBUG] java/awt/print/Dialog/DialogCopies.java does not show instruction
  • 544193a: 8247980: Exclusive execution of java/util/stream tests slows down tier1
  • 1f8af52: 8273314: Add tier4 test groups
  • 699865f: 8259039: Passing different version to --release flag than javac version output warning
  • ... and 19 more: https://git.openjdk.java.net/jdk/compare/9c5441c9c4eea2ea4ba78ee426729bf646dc042d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 20, 2021
@openjdk
Copy link

openjdk bot commented Sep 20, 2021

@calvinccheung Pushed as commit a67f0f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@calvinccheung calvinccheung deleted the 8273505-segv-link_shared_classes branch Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
3 participants