Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273909: vmTestbase/nsk/jdi/Event/request/request001 can still fail with "ERROR: new event is not ThreadStartEvent" #5567

Closed
wants to merge 1 commit into from

Conversation

@alexmenkov
Copy link

@alexmenkov alexmenkov commented Sep 17, 2021

The changes fixes discovered issues with getEventSetForThreadStartDeath method and its callers:

  • getEventSetForThreadStartDeath must resume suspended thread(s), otherwise it can never get desired event;
  • callers should not call addCountFilter;
    also simplifies getEventSetForThreadStartDeath.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273909: vmTestbase/nsk/jdi/Event/request/request001 can still fail with "ERROR: new event is not ThreadStartEvent"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5567/head:pull/5567
$ git checkout pull/5567

Update a local copy of the PR:
$ git checkout pull/5567
$ git pull https://git.openjdk.java.net/jdk pull/5567/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5567

View PR using the GUI difftool:
$ git pr show -t 5567

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5567.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 17, 2021

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2021

@alexmenkov The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 17, 2021

Webrevs

Loading

Copy link
Contributor

@plummercj plummercj left a comment

Looks good, and the request001 now passes in loom with the changes.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2021

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273909: vmTestbase/nsk/jdi/Event/request/request001 can still fail with "ERROR: new event is not ThreadStartEvent"

Reviewed-by: cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 6f3e40c: 8273825: TestIRMatching.java fails after JDK-8266550
  • a561eac: 8273895: compiler/ciReplay/TestVMNoCompLevel.java fails due to wrong data size with TieredStopAtLevel=2,3
  • d2388b7: 8273959: Some metaspace diagnostic switches should be develop
  • dc7f452: 8273815: move have_special_privileges to os_posix for POSIX platforms
  • 7c9868c: 8273454: C2: Transform (-a)(-b) into ab
  • bb9d142: 8273958: gtest/MetaspaceGtests executes unnecessary tests in debug builds
  • 2a2e919: 8273685: Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction
  • 8302061: 8273774: CDSPluginTest should only expect classes_nocoops.jsa exists on supported 64-bit platforms
  • 2f8c221: 8273681: Add Vector API vs Arrays.mismatch intrinsic benchmark
  • 17f7a45: 8273913: Problem list some headful client jtreg tests that fail on macOS 12
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/8c022e2c174cca2b03e8fdf4fadad42bc11c65f1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 17, 2021
@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Sep 20, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2021

Going to push as commit 5fde4b6.
Since your change was applied there have been 30 commits pushed to the master branch:

  • 04891c9: 8273912: Add threadControl_dumpThread(jthread) function
  • 5c21c00: 8267163: Rename anonymous loader tests to hidden loader tests
  • b3b4b1c: 8273907: Cleanup redundant Math.max/min calls in DefaultHighlighter
  • a67f0f9: 8273505: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#default-cl crashed with SIGSEGV in MetaspaceShared::link_shared_classes
  • 26e5e9a: 8273654: JFR: Remove unused SecuritySupport.setAccessible(Field)
  • 4b3a4ff: 8273940: vmTestbase/vm/mlvm/meth/stress/gc/callSequencesDuringGC/Test.java crashes in full gc during VM exit
  • dad5d27: 8272867: JFR: ManagementSupport.removeBefore() lost coverage
  • 48aff23: 8272515: JFR: Names should only be valid Java identifiers
  • 4d95a5d: 8273933: [TESTBUG] Test must run without preallocated exceptions
  • 9aa12da: 8273934: Remove unused perfcounters
  • ... and 20 more: https://git.openjdk.java.net/jdk/compare/8c022e2c174cca2b03e8fdf4fadad42bc11c65f1...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2021

@alexmenkov Pushed as commit 5fde4b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@alexmenkov alexmenkov deleted the ThreadStartDeath branch Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants