New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8267163: Rename anonymous loader tests to hidden loader tests #5570
JDK-8267163: Rename anonymous loader tests to hidden loader tests #5570
Conversation
|
@hseigel Harold, please review when you have a chance. |
Webrevs
|
@mseledts This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 19 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
I discovered that I had to update ProblemList-Xcomp, it is a trivial renaming for problem listed test. |
David, Harold, thank you for review. All testing passed. /integrate |
Going to push as commit 5c21c00.
Your commit was automatically rebased without conflicts. |
Please review this simple change that renames vm/mlvm tests and test package name from anonymous to hidden.
Testing:
Ran open/test/hotspot/jtreg/vmTestbase/vm/mlvm on MacOS-x64: PASS
Running open/test/hotspot/jtreg/vmTestbase/vm/mlvm on multiple platforms: in progress ...
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5570/head:pull/5570
$ git checkout pull/5570
Update a local copy of the PR:
$ git checkout pull/5570
$ git pull https://git.openjdk.java.net/jdk pull/5570/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5570
View PR using the GUI difftool:
$ git pr show -t 5570
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5570.diff