Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8267163: Rename anonymous loader tests to hidden loader tests #5570

Closed

Conversation

mseledts
Copy link
Member

@mseledts mseledts commented Sep 18, 2021

Please review this simple change that renames vm/mlvm tests and test package name from anonymous to hidden.
Testing:
Ran open/test/hotspot/jtreg/vmTestbase/vm/mlvm on MacOS-x64: PASS
Running open/test/hotspot/jtreg/vmTestbase/vm/mlvm on multiple platforms: in progress ...


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267163: Rename anonymous loader tests to hidden loader tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5570/head:pull/5570
$ git checkout pull/5570

Update a local copy of the PR:
$ git checkout pull/5570
$ git pull https://git.openjdk.java.net/jdk pull/5570/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5570

View PR using the GUI difftool:
$ git pr show -t 5570

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5570.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 18, 2021

👋 Welcome back mseledtsov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mseledts
Copy link
Member Author

@mseledts mseledts commented Sep 18, 2021

@hseigel Harold, please review when you have a chance.

@openjdk openjdk bot added the rfr label Sep 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 18, 2021

@mseledts The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Sep 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 18, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Hi Misha,

This renaming seems fine.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2021

@mseledts This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267163: Rename anonymous loader tests to hidden loader tests

Reviewed-by: dholmes, hseigel

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • b3b4b1c: 8273907: Cleanup redundant Math.max/min calls in DefaultHighlighter
  • a67f0f9: 8273505: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#default-cl crashed with SIGSEGV in MetaspaceShared::link_shared_classes
  • 26e5e9a: 8273654: JFR: Remove unused SecuritySupport.setAccessible(Field)
  • 4b3a4ff: 8273940: vmTestbase/vm/mlvm/meth/stress/gc/callSequencesDuringGC/Test.java crashes in full gc during VM exit
  • dad5d27: 8272867: JFR: ManagementSupport.removeBefore() lost coverage
  • 48aff23: 8272515: JFR: Names should only be valid Java identifiers
  • 4d95a5d: 8273933: [TESTBUG] Test must run without preallocated exceptions
  • 9aa12da: 8273934: Remove unused perfcounters
  • 4da45c4: 8270609: [TESTBUG] java/awt/print/Dialog/DialogCopies.java does not show instruction
  • 544193a: 8247980: Exclusive execution of java/util/stream tests slows down tier1
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/2a2e9190d4e866ac1b712feb0e4bb61d08e112c7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 20, 2021
Copy link
Member

@hseigel hseigel left a comment

The changes look good. Thanks for doing this.
Harold

@mseledts
Copy link
Member Author

@mseledts mseledts commented Sep 20, 2021

I discovered that I had to update ProblemList-Xcomp, it is a trivial renaming for problem listed test.

@mseledts
Copy link
Member Author

@mseledts mseledts commented Sep 20, 2021

David, Harold, thank you for review. All testing passed.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2021

Going to push as commit 5c21c00.
Since your change was applied there have been 19 commits pushed to the master branch:

  • b3b4b1c: 8273907: Cleanup redundant Math.max/min calls in DefaultHighlighter
  • a67f0f9: 8273505: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#default-cl crashed with SIGSEGV in MetaspaceShared::link_shared_classes
  • 26e5e9a: 8273654: JFR: Remove unused SecuritySupport.setAccessible(Field)
  • 4b3a4ff: 8273940: vmTestbase/vm/mlvm/meth/stress/gc/callSequencesDuringGC/Test.java crashes in full gc during VM exit
  • dad5d27: 8272867: JFR: ManagementSupport.removeBefore() lost coverage
  • 48aff23: 8272515: JFR: Names should only be valid Java identifiers
  • 4d95a5d: 8273933: [TESTBUG] Test must run without preallocated exceptions
  • 9aa12da: 8273934: Remove unused perfcounters
  • 4da45c4: 8270609: [TESTBUG] java/awt/print/Dialog/DialogCopies.java does not show instruction
  • 544193a: 8247980: Exclusive execution of java/util/stream tests slows down tier1
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/2a2e9190d4e866ac1b712feb0e4bb61d08e112c7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2021

@mseledts Pushed as commit 5c21c00.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
3 participants